HBASE-24648 Remove the legacy 'forceSplit' related code at region ser… by Apache9 · Pull Request #1990 · apache/hbase

Apache9 · 2020-06-27T15:36:26Z

…ver side

Apache-HBase · 2020-06-27T16:10:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 48s	master passed
+1 💚	compile	0m 54s	master passed
+1 💚	shadedjars	5m 26s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 32s	the patch passed
+1 💚	compile	0m 55s	the patch passed
+1 💚	javac	0m 55s	the patch passed
+1 💚	shadedjars	5m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
-1 ❌	unit	7m 10s	hbase-server in the patch failed.
		30m 25s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1990
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9cebe6895da2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `47742b2`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/1/testReport/
Max. process+thread count	620 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-27T16:13:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 45s	master passed
+1 💚	checkstyle	1m 22s	master passed
+1 💚	spotbugs	1m 58s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	checkstyle	1m 16s	hbase-server: The patch generated 0 new + 505 unchanged - 5 fixed = 505 total (was 510)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 7s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
-1 ❌	spotbugs	2m 8s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		33m 1s

Reason	Tests
FindBugs	module:hbase-server
	org.apache.hadoop.hbase.regionserver.HRegion.checkSplit(boolean) has Optional return type and returns explicit null At HRegion.java:and returns explicit null At HRegion.java:[line 8557]

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1990
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 302a5427fbdd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `47742b2`
spotbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-27T16:14:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 29s	master passed
+1 💚	compile	1m 8s	master passed
+1 💚	shadedjars	5m 55s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 42s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 9s	the patch passed
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
+1 💚	shadedjars	6m 19s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 51s	hbase-server in the patch failed.
		_ Other Tests _
-1 ❌	unit	7m 52s	hbase-server in the patch failed.
		34m 30s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1990
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c7e349246346 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `47742b2`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/1/testReport/
Max. process+thread count	526 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

Left few comments.

...erver/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

virajjasani · 2020-06-28T09:04:34Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

-        region.startRegionOperation(Operation.SPLIT_REGION);
-        r.forceSplit(null);
-        // Even after setting force split if split policy says no to split then we should not split.
-        shouldSplit = region.getSplitPolicy().shouldSplit() && !info.isMetaRegion();


After this change, region.getSplitPolicy() is no longer read by source code, only test code. If test code can get splitPolicy using reflection, maybe we can remove getSplitPolicy() from HRegion. Anyways, not a strong preference w.r.t this PR, we are good.

Changed getSplitPolicy to package private and added a VisibleForTesting annotation.

Apache9 · 2020-06-28T12:42:43Z

The failed UT is TestHeapSize, seems we lost track for the heap size of HRegion for a long time...

Need to dig more to see how to fix it...

Apache-HBase · 2020-06-28T16:56:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 49s	master passed
+1 💚	checkstyle	1m 12s	master passed
+1 💚	spotbugs	2m 5s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 21s	the patch passed
+1 💚	checkstyle	1m 20s	hbase-server: The patch generated 0 new + 505 unchanged - 5 fixed = 505 total (was 510)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 35s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 46s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		36m 15s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1990
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 909d2ec97cbc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46bf894`
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-28T18:56:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 0s	master passed
+1 💚	compile	1m 3s	master passed
+1 💚	shadedjars	5m 40s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 39s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 5s	the patch passed
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
+1 💚	shadedjars	5m 40s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 40s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	130m 26s	hbase-server in the patch passed.
		156m 1s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1990
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 886ea48e778b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46bf894`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/2/testReport/
Max. process+thread count	4309 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-28T19:02:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 34s	master passed
+1 💚	compile	0m 55s	master passed
+1 💚	shadedjars	5m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 34s	the patch passed
+1 💚	compile	0m 57s	the patch passed
+1 💚	javac	0m 57s	the patch passed
+1 💚	shadedjars	5m 32s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	138m 3s	hbase-server in the patch passed.
		162m 21s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1990
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ad975c31fe44 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46bf894`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/2/testReport/
Max. process+thread count	4353 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…ver side

Apache-HBase · 2020-06-29T03:06:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 51s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 23s	master passed
+1 💚	checkstyle	1m 15s	master passed
+1 💚	spotbugs	1m 55s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 23s	the patch passed
-0 ⚠️	checkstyle	1m 15s	hbase-server: The patch generated 1 new + 506 unchanged - 5 fixed = 507 total (was 511)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 6s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 8s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		35m 44s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1990
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 54b3eec55f53 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46bf894`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-29T05:29:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 29s	master passed
+1 💚	compile	1m 7s	master passed
+1 💚	shadedjars	5m 56s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 43s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 11s	the patch passed
+1 💚	compile	1m 5s	the patch passed
+1 💚	javac	1m 5s	the patch passed
+1 💚	shadedjars	6m 14s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 51s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	148m 17s	hbase-server in the patch passed.
		179m 20s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1990
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9c9e41ec27b5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46bf894`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/3/testReport/
Max. process+thread count	4267 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-29T05:37:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 50s	master passed
+1 💚	compile	0m 53s	master passed
+1 💚	shadedjars	5m 36s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 30s	the patch passed
+1 💚	compile	0m 54s	the patch passed
+1 💚	javac	0m 54s	the patch passed
+1 💚	shadedjars	5m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
-1 ❌	unit	159m 16s	hbase-server in the patch failed.
		187m 36s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1990
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 888222d1d378 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46bf894`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/3/testReport/
Max. process+thread count	3619 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-29T06:12:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 22s	master passed
+1 💚	checkstyle	1m 15s	master passed
+1 💚	spotbugs	1m 56s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	checkstyle	1m 18s	hbase-server: The patch generated 0 new + 506 unchanged - 5 fixed = 506 total (was 511)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 8s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 7s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		32m 8s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1990
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux d75e31b7d7fd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46bf894`
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1

Apache-HBase · 2020-06-29T08:35:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 19s	master passed
+1 💚	compile	1m 6s	master passed
+1 💚	shadedjars	5m 53s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 40s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 11s	the patch passed
+1 💚	compile	1m 7s	the patch passed
+1 💚	javac	1m 7s	the patch passed
+1 💚	shadedjars	6m 9s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 52s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	148m 9s	hbase-server in the patch passed.
		174m 52s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1990
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bb1d5ac656ba 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46bf894`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/4/testReport/
Max. process+thread count	4195 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-29T08:44:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 37s	master passed
+1 💚	compile	0m 56s	master passed
+1 💚	shadedjars	5m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 31s	the patch passed
+1 💚	compile	0m 55s	the patch passed
+1 💚	javac	0m 55s	the patch passed
+1 💚	shadedjars	5m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	159m 25s	hbase-server in the patch passed.
		183m 28s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1990
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fbfbd3b53377 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46bf894`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/4/testReport/
Max. process+thread count	3500 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1990/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…ver side (#1990) Signed-off-by: Viraj Jasani <vjasani@apache.org>

…ver side (#1990) Addendum to fix TestHeapSize

Revert "HBASE-24648 Remove the legacy 'forceSplit' related code at region server side (#1990)" This reverts commit bfec964.

…ver side (apache#1990) Signed-off-by: Viraj Jasani <vjasani@apache.org>

…ver side (apache#1990) Addendum to fix TestHeapSize

Apache9 self-assigned this Jun 27, 2020

virajjasani reviewed Jun 28, 2020

View reviewed changes

Apache9 force-pushed the HBASE-24648 branch from 4f9abee to 1445121 Compare June 28, 2020 16:17

HBASE-24648 Remove the legacy 'forceSplit' related code at region ser…

78a6285

…ver side

Apache9 force-pushed the HBASE-24648 branch from 1445121 to 78a6285 Compare June 29, 2020 02:22

fix checkstyle warning

d9fc06f

virajjasani approved these changes Jun 29, 2020

View reviewed changes

Apache9 merged commit 37b863b into apache:master Jun 29, 2020

asfgit pushed a commit that referenced this pull request Jun 29, 2020

HBASE-24648 Remove the legacy 'forceSplit' related code at region ser…

3effd28

…ver side (#1990) Signed-off-by: Viraj Jasani <vjasani@apache.org>

saintstack added a commit that referenced this pull request Jun 29, 2020

HBASE-24648 Remove the legacy 'forceSplit' related code at region ser…

0dd42f7

…ver side (#1990) Addendum to fix TestHeapSize

saintstack added a commit that referenced this pull request Jun 29, 2020

HBASE-24648 Remove the legacy 'forceSplit' related code at region ser…

bfec964

…ver side (#1990) Addendum to fix TestHeapSize

saintstack added a commit that referenced this pull request Jun 30, 2020

HBASE-24661 TestHeapSize.testSizes failure

2c43f6c

Revert "HBASE-24648 Remove the legacy 'forceSplit' related code at region server side (#1990)" This reverts commit bfec964.

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020

HBASE-24648 Remove the legacy 'forceSplit' related code at region ser…

0269c10

…ver side (apache#1990) Signed-off-by: Viraj Jasani <vjasani@apache.org>

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020

HBASE-24648 Remove the legacy 'forceSplit' related code at region ser…

0e98927

…ver side (apache#1990) Addendum to fix TestHeapSize

Conversation

Apache9 commented Jun 27, 2020

Uh oh!

Apache-HBase commented Jun 27, 2020

Uh oh!

Apache-HBase commented Jun 27, 2020

Uh oh!

Apache-HBase commented Jun 27, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

virajjasani Jun 28, 2020

Choose a reason for hiding this comment

Uh oh!

Apache9 Jun 29, 2020

Choose a reason for hiding this comment

Uh oh!

Apache9 commented Jun 28, 2020

Uh oh!

Apache-HBase commented Jun 28, 2020

Uh oh!

Apache-HBase commented Jun 28, 2020

Uh oh!

Apache-HBase commented Jun 28, 2020

Uh oh!

Apache-HBase commented Jun 29, 2020

Uh oh!

Apache-HBase commented Jun 29, 2020

Uh oh!

Apache-HBase commented Jun 29, 2020

Uh oh!

Apache-HBase commented Jun 29, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jun 29, 2020

Uh oh!

Apache-HBase commented Jun 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants