HBASE-21596 Delete for a specific cell version can bring back version…

[wchevreuil]

…… (#2009)

Had to resolve some conflicts while cherry picking into branch-2. Created branch-2 PR to run pre commit tests.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 1s	branch-2 passed
+1 💚	checkstyle	1m 22s	branch-2 passed
+1 💚	spotbugs	2m 12s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 34s	the patch passed
+1 💚	checkstyle	1m 15s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	14m 0s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 14s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		37m 44s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2036
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux d2924a1bc9cd 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / 5fcffae
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 28s	branch-2 passed
+1 💚	compile	1m 5s	branch-2 passed
+1 💚	shadedjars	6m 1s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 44s	hbase-server in branch-2 failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 0s	the patch passed
+1 💚	compile	1m 5s	the patch passed
+1 💚	javac	1m 5s	the patch passed
+1 💚	shadedjars	6m 40s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 49s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	140m 51s	hbase-server in the patch passed.
		168m 24s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2036
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux dfdd04e16907 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / 5fcffae
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/testReport/
Max. process+thread count	3643 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 48s	branch-2 passed
+1 💚	compile	0m 54s	branch-2 passed
+1 💚	shadedjars	5m 4s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	compile	0m 54s	the patch passed
+1 💚	javac	0m 54s	the patch passed
+1 💚	shadedjars	5m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	151m 25s	hbase-server in the patch passed.
		174m 41s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#2036
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux da9ba2d3c764 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / 5fcffae
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/testReport/
Max. process+thread count	3501 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache9]

Not sure why I missed this one...

Have you read https://issues.apache.org/jira/browse/HBASE-15968?

Thanks.

[Apache9]

And if you are talking about filter, the semantic for readVersions is the number of versions before filtering, not the version after fitlering. If you want to limit the version after filtering, you can use readAllVersions and append a filter at last to limit the versions returned.

[Apache9]

And if you are talking about filter, the semantic for readVersions is the number of versions before filtering, not the version after fitlering. If you want to limit the version after filtering, you can use readAllVersions and append a filter at last to limit the versions returned.

Oh, skimmed HBASE-17125. Seems we do not go to this direction. Anyway, on the solution for 'deleted versions come back', I think the final solution is HBASE-15968.

Thanks.

[wchevreuil]

And if you are talking about filter, the semantic for readVersions is the number of versions before filtering, not the version after fitlering. If you want to limit the version after filtering, you can use readAllVersions and append a filter at last to limit the versions returned.

Oh, skimmed HBASE-17125. Seems we do not go to this direction. Anyway, on the solution for 'deleted versions come back', I think the final solution is HBASE-15968.

Thanks.

Thanks for pointing HBASE-15968. This has been a recurring source of confusion and complain among our customer base, having inconsistent results prior and after compaction isn't just correct. Should we make HBASE-15968 the default behaviour, and not optional?