Skip to content

HBASE-25452 Use MatcherAssert.assertThat instead of org.junit.Assert.…#2826

Merged
Apache9 merged 1 commit intoapache:masterfrom
Apache9:HBASE-25452
Dec 30, 2020
Merged

HBASE-25452 Use MatcherAssert.assertThat instead of org.junit.Assert.…#2826
Apache9 merged 1 commit intoapache:masterfrom
Apache9:HBASE-25452

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented Dec 29, 2020

…assertThat

@Apache9 Apache9 self-assigned this Dec 29, 2020
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for branch
+1 💚 mvninstall 4m 36s master passed
+1 💚 checkstyle 3m 4s master passed
+1 💚 spotbugs 6m 38s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 3s the patch passed
+1 💚 checkstyle 0m 31s The patch passed checkstyle in hbase-client
+1 💚 checkstyle 0m 18s The patch passed checkstyle in hbase-zookeeper
+1 💚 checkstyle 0m 13s The patch passed checkstyle in hbase-replication
+1 💚 checkstyle 0m 12s The patch passed checkstyle in hbase-http
+1 💚 checkstyle 1m 19s hbase-server: The patch generated 0 new + 38 unchanged - 1 fixed = 38 total (was 39)
+1 💚 checkstyle 0m 17s The patch passed checkstyle in hbase-rest
+1 💚 checkstyle 0m 12s The patch passed checkstyle in hbase-hbtop
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 20m 34s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 8m 19s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 17s The patch does not generate ASF License warnings.
64m 44s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2826
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 2ec4bb7abf2a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d963342
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-client hbase-zookeeper hbase-replication hbase-http hbase-server hbase-rest hbase-hbtop U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for branch
+1 💚 mvninstall 4m 13s master passed
+1 💚 compile 3m 22s master passed
+1 💚 shadedjars 6m 40s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 39s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 4m 4s the patch passed
+1 💚 compile 3m 21s the patch passed
+1 💚 javac 3m 21s the patch passed
+1 💚 shadedjars 6m 39s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 39s the patch passed
_ Other Tests _
+1 💚 unit 1m 6s hbase-client in the patch passed.
+1 💚 unit 0m 43s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 27s hbase-replication in the patch passed.
+1 💚 unit 0m 41s hbase-http in the patch passed.
+1 💚 unit 130m 53s hbase-server in the patch passed.
+1 💚 unit 3m 24s hbase-rest in the patch passed.
+1 💚 unit 0m 48s hbase-hbtop in the patch passed.
176m 17s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2826
Optional Tests javac javadoc unit shadedjars compile
uname Linux 453436f73bf4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d963342
Default Java AdoptOpenJDK-11.0.6+10
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/testReport/
Max. process+thread count 4043 (vs. ulimit of 30000)
modules C: hbase-client hbase-zookeeper hbase-replication hbase-http hbase-server hbase-rest hbase-hbtop U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for branch
+1 💚 mvninstall 3m 40s master passed
+1 💚 compile 3m 1s master passed
+1 💚 shadedjars 6m 29s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 20s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 29s the patch passed
+1 💚 compile 3m 3s the patch passed
+1 💚 javac 3m 3s the patch passed
+1 💚 shadedjars 6m 38s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 23s the patch passed
_ Other Tests _
+1 💚 unit 1m 3s hbase-client in the patch passed.
+1 💚 unit 0m 43s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 27s hbase-replication in the patch passed.
+1 💚 unit 0m 42s hbase-http in the patch passed.
+1 💚 unit 138m 26s hbase-server in the patch passed.
+1 💚 unit 4m 0s hbase-rest in the patch passed.
+1 💚 unit 0m 46s hbase-hbtop in the patch passed.
181m 51s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2826
Optional Tests javac javadoc unit shadedjars compile
uname Linux 40b860f8151f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d963342
Default Java AdoptOpenJDK-1.8.0_232-b09
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/testReport/
Max. process+thread count 4580 (vs. ulimit of 30000)
modules C: hbase-client hbase-zookeeper hbase-replication hbase-http hbase-server hbase-rest hbase-hbtop U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@infraio infraio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache9 Apache9 merged commit 55a4eca into apache:master Dec 30, 2020
Apache9 added a commit that referenced this pull request Dec 30, 2020
…assertThat (#2826)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
Apache9 added a commit that referenced this pull request Dec 30, 2020
…assertThat (#2826)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
Apache9 added a commit that referenced this pull request Dec 30, 2020
…assertThat (#2826)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants