HBASE-25712 backport HBASE-25962 to branch-1#3104
Closed
joshelser wants to merge 2 commits intoapache:branch-1from
Closed
HBASE-25712 backport HBASE-25962 to branch-1#3104joshelser wants to merge 2 commits intoapache:branch-1from
joshelser wants to merge 2 commits intoapache:branch-1from
Conversation
HBASE-25692 ensures that we do not leak any InputStream (Socket) which would otherwise remain as CLOSE_WAIT until the java process exits. These orphaned sockets would eventually saturate Linux network and file limits.
Member
Author
|
Only ran TestWALFactory locally. Expecting other things to break, but I'll let QA report those. |
|
💔 -1 overall
This message was automatically generated. |
wchevreuil
approved these changes
Mar 30, 2021
Contributor
wchevreuil
left a comment
wchevreuil
left a comment
There was a problem hiding this comment.
LGTM, just have a thought on whether catching throwable to avoid any risk of this leak still happening.
| return reader; | ||
| } | ||
| } catch (IOException e) { | ||
| } catch (Exception e) { |
Contributor
There was a problem hiding this comment.
Catching Exception is enough? No need to catch Throwable to avoid any possibility of still getting this leak?
Member
Author
There was a problem hiding this comment.
Catching throwable is usually a smell as it also encompasses java.lang.Error's. We definitely don't want to catch Error's as we want to let them propagate as quickly as possible.
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Apr 2, 2021
HBASE-25692 ensures that we do not leak any InputStream (Socket) which would otherwise remain as CLOSE_WAIT until the java process exits. These orphaned sockets would eventually saturate Linux network and file limits. Closes #3104 Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-25692 ensures that we do not leak any InputStream (Socket)
which would otherwise remain as CLOSE_WAIT until the java process
exits. These orphaned sockets would eventually saturate Linux network
and file limits.