HBASE-25715 Add a basic CompactionServer which only keep heartbeat with HMaster by nyl3532016 · Pull Request #3115 · apache/hbase

nyl3532016 · 2021-04-01T07:43:29Z

No description provided.

Apache-HBase · 2021-04-01T09:04:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 53s	HBASE-25714 passed
+1 💚	compile	6m 42s	HBASE-25714 passed
+1 💚	checkstyle	2m 9s	HBASE-25714 passed
+1 💚	spotbugs	7m 39s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 10s	the patch passed
+1 💚	compile	6m 54s	the patch passed
+1 💚	cc	6m 54s	the patch passed
+1 💚	javac	6m 54s	the patch passed
-0 ⚠️	checkstyle	0m 25s	hbase-common: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2)
-0 ⚠️	checkstyle	1m 16s	hbase-server: The patch generated 21 new + 137 unchanged - 0 fixed = 158 total (was 137)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 31s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	hbaseprotoc	2m 35s	the patch passed
-1 ❌	spotbugs	2m 40s	hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 47s	The patch does not generate ASF License warnings.
		79m 42s

Reason	Tests
FindBugs	module:hbase-server
	Inconsistent synchronization of org.apache.hadoop.hbase.compactionserver.HCompactionServer.asyncClusterConnection; locked 50% of time Unsynchronized access at HCompactionServer.java:50% of time Unsynchronized access at HCompactionServer.java:[line 135]
	Inconsistent synchronization of org.apache.hadoop.hbase.compactionserver.HCompactionServer.rpcClient; locked 50% of time Unsynchronized access at HCompactionServer.java:50% of time Unsynchronized access at HCompactionServer.java:[line 358]

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname	Linux 4b5b7a4f0d13 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotbugs	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-01T10:52:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 52s	HBASE-25714 passed
+1 💚	compile	2m 37s	HBASE-25714 passed
+1 💚	shadedjars	7m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 40s	the patch passed
+1 💚	compile	2m 39s	the patch passed
+1 💚	javac	2m 39s	the patch passed
+1 💚	shadedjars	7m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 47s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 40s	hbase-common in the patch passed.
+1 💚	unit	1m 12s	hbase-client in the patch passed.
+1 💚	unit	148m 55s	hbase-server in the patch passed.
		188m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6ab7250c54e4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/1/testReport/
Max. process+thread count	4568 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-01T12:41:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 59s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 59s	HBASE-25714 passed
+1 💚	compile	3m 35s	HBASE-25714 passed
+1 💚	shadedjars	9m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 53s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 58s	the patch passed
+1 💚	compile	3m 29s	the patch passed
+1 💚	javac	3m 29s	the patch passed
+1 💚	shadedjars	9m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 8s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	2m 57s	hbase-common in the patch passed.
+1 💚	unit	2m 13s	hbase-client in the patch passed.
+1 💚	unit	244m 58s	hbase-server in the patch passed.
		297m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bde10ba1a066 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/1/testReport/
Max. process+thread count	2807 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-01T14:10:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 12s	HBASE-25714 passed
+1 💚	compile	6m 33s	HBASE-25714 passed
+1 💚	checkstyle	2m 15s	HBASE-25714 passed
+1 💚	spotbugs	7m 55s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 57s	the patch passed
+1 💚	compile	6m 29s	the patch passed
+1 💚	cc	6m 29s	the patch passed
+1 💚	javac	6m 29s	the patch passed
+1 💚	checkstyle	2m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 44s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	hbaseprotoc	2m 24s	the patch passed
+1 💚	spotbugs	8m 29s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 42s	The patch does not generate ASF License warnings.
		75m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname	Linux 94ad1be0e6b6 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-01T16:00:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 14s	HBASE-25714 passed
+1 💚	compile	4m 6s	HBASE-25714 passed
+1 💚	shadedjars	9m 3s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 51s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 11s	the patch passed
+1 💚	compile	3m 7s	the patch passed
+1 💚	javac	3m 7s	the patch passed
+1 💚	shadedjars	7m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 0s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 48s	hbase-common in the patch passed.
+1 💚	unit	1m 22s	hbase-client in the patch passed.
+1 💚	unit	140m 15s	hbase-server in the patch passed.
		186m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7542b54aaa62 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/2/testReport/
Max. process+thread count	4043 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-01T16:02:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 36s	HBASE-25714 passed
+1 💚	compile	2m 39s	HBASE-25714 passed
+1 💚	shadedjars	7m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 34s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 33s	the patch passed
+1 💚	compile	2m 36s	the patch passed
+1 💚	javac	2m 36s	the patch passed
+1 💚	shadedjars	7m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 46s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 39s	hbase-common in the patch passed.
+1 💚	unit	1m 12s	hbase-client in the patch passed.
+1 💚	unit	149m 7s	hbase-server in the patch passed.
		187m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 76ff580a8cad 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/2/testReport/
Max. process+thread count	4649 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

nyl3532016 · 2021-04-04T08:23:19Z

The master UI after CompactionServer add

Apache-HBase · 2021-04-04T09:38:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 11s	HBASE-25714 passed
+1 💚	compile	6m 29s	HBASE-25714 passed
+1 💚	checkstyle	2m 13s	HBASE-25714 passed
+1 💚	spotbugs	7m 45s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 2s	the patch passed
+1 💚	compile	6m 30s	the patch passed
+1 💚	cc	6m 30s	the patch passed
+1 💚	javac	6m 30s	the patch passed
-0 ⚠️	checkstyle	1m 15s	hbase-server: The patch generated 1 new + 137 unchanged - 0 fixed = 138 total (was 137)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 46s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	hbaseprotoc	2m 24s	the patch passed
+1 💚	spotbugs	8m 44s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 44s	The patch does not generate ASF License warnings.
		75m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname	Linux 6b80fb561f1e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-04T11:24:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 22s	HBASE-25714 passed
+1 💚	compile	3m 7s	HBASE-25714 passed
+1 💚	shadedjars	7m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 47s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 12s	the patch passed
+1 💚	compile	3m 7s	the patch passed
+1 💚	javac	3m 7s	the patch passed
+1 💚	shadedjars	7m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 45s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 58s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 47s	hbase-common in the patch passed.
+1 💚	unit	1m 22s	hbase-client in the patch passed.
+1 💚	unit	140m 42s	hbase-server in the patch passed.
		182m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b8640262ed61 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/3/testReport/
Max. process+thread count	4246 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-04T11:31:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 39s	HBASE-25714 passed
+1 💚	compile	2m 38s	HBASE-25714 passed
+1 💚	shadedjars	7m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 37s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 40s	the patch passed
+1 💚	compile	2m 38s	the patch passed
+1 💚	javac	2m 38s	the patch passed
+1 💚	shadedjars	7m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 46s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 39s	hbase-common in the patch passed.
+1 💚	unit	1m 13s	hbase-client in the patch passed.
+1 💚	unit	149m 39s	hbase-server in the patch passed.
		189m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 078e53d69a28 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/3/testReport/
Max. process+thread count	4844 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

Skimmed, the code for HCompactionServer is very like HRegionServer, just some naming changes...

Could we try to reduce the duplicated code? By introducing a common base class, or a util class?

Thanks.

Apache9 · 2021-04-07T08:32:31Z

hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CSRpcServices.java

I believe we have this method at ohter places too, is it possible to reuse the code instead of copy the code?

Yes, Let me try to reduce the code

Apache-HBase · 2021-04-11T15:47:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 38s	HBASE-25714 passed
+1 💚	compile	2m 37s	HBASE-25714 passed
+1 💚	shadedjars	7m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 37s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 34s	the patch passed
+1 💚	compile	2m 37s	the patch passed
+1 💚	javac	2m 37s	the patch passed
+1 💚	shadedjars	7m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 46s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 38s	hbase-common in the patch passed.
+1 💚	unit	1m 12s	hbase-client in the patch passed.
-1 ❌	unit	8m 3s	hbase-server in the patch failed.
		45m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 92ccf39ea682 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/5/testReport/
Max. process+thread count	493 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-11T15:52:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 33s	HBASE-25714 passed
+1 💚	compile	3m 18s	HBASE-25714 passed
+1 💚	shadedjars	8m 6s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 50s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 21s	the patch passed
+1 💚	compile	3m 14s	the patch passed
+1 💚	javac	3m 14s	the patch passed
+1 💚	shadedjars	8m 3s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 1s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 48s	hbase-common in the patch passed.
+1 💚	unit	1m 20s	hbase-client in the patch passed.
-1 ❌	unit	8m 50s	hbase-server in the patch failed.
		51m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 29d34f943b18 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/5/testReport/
Max. process+thread count	425 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-11T16:16:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 32s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 45s	HBASE-25714 passed
+1 💚	compile	6m 27s	HBASE-25714 passed
+1 💚	checkstyle	2m 6s	HBASE-25714 passed
+1 💚	spotbugs	7m 45s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 44s	the patch passed
+1 💚	compile	6m 23s	the patch passed
+1 💚	cc	6m 23s	the patch passed
+1 💚	javac	6m 23s	the patch passed
-0 ⚠️	checkstyle	1m 8s	hbase-server: The patch generated 6 new + 225 unchanged - 0 fixed = 231 total (was 225)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 1s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	hbaseprotoc	2m 23s	the patch passed
-1 ❌	spotbugs	2m 19s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 49s	The patch does not generate ASF License warnings.
		74m 54s

Reason	Tests
FindBugs	module:hbase-server
	Field HRegionServer.clusterId masks field in superclass org.apache.hadoop.hbase.AbstractServer In HRegionServer.java:superclass org.apache.hadoop.hbase.AbstractServer In HRegionServer.java

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname	Linux 2be67082da13 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotbugs	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/5/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	97 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-12T04:07:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 29s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 42s	HBASE-25714 passed
+1 💚	compile	6m 27s	HBASE-25714 passed
+1 💚	checkstyle	2m 6s	HBASE-25714 passed
+1 💚	spotbugs	7m 42s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 42s	the patch passed
+1 💚	compile	6m 22s	the patch passed
+1 💚	cc	6m 22s	the patch passed
+1 💚	javac	6m 22s	the patch passed
+1 💚	checkstyle	2m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	23m 7s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	hbaseprotoc	2m 56s	the patch passed
+1 💚	spotbugs	10m 40s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 42s	The patch does not generate ASF License warnings.
		81m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname	Linux 0918b24e46ed 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/6/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…th HMaster

Apache9 · 2021-04-12T13:07:53Z

...-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CompactionServerServices.java

What's this class used for?

Just like RegionServerServices, useless in this patch. Remove first, I will add this class later.

Apache9 · 2021-04-12T13:10:33Z

hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/HCompactionServer.java

I think this only difference here between the similiar method in HRegionServer is how to call newStub? We need to use different types of protobuf Interface. So can we move this method up to AbstractServer?

Abstract a method createMasterStub, the original return value master serverName is only used for debug, so return actual stub created instead.

Apache9 · 2021-04-12T13:15:02Z

hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java

  // server manager to deal with region server info
  private volatile ServerManager serverManager;

+  private volatile CompactionServerManager compactionServerManager;


Is it possible to reuse ServerManager here? Just asking...

I think no need now, has few duplicated codes. CompactionServer do not register to zookeeper, so compactionServerManager is more simple without zookeeper interaction.

Apache-HBase · 2021-04-12T14:13:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 21s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 3s	HBASE-25714 passed
+1 💚	compile	6m 29s	HBASE-25714 passed
+1 💚	checkstyle	2m 14s	HBASE-25714 passed
+1 💚	spotbugs	7m 52s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 58s	the patch passed
+1 💚	compile	6m 28s	the patch passed
+1 💚	cc	6m 28s	the patch passed
+1 💚	javac	6m 28s	the patch passed
+1 💚	checkstyle	2m 15s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 45s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	hbaseprotoc	2m 25s	the patch passed
+1 💚	spotbugs	8m 38s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 43s	The patch does not generate ASF License warnings.
		75m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname	Linux 37771878e03a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/8/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-14T05:48:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 1s	The patch does not contain any @author tags.
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 41s	HBASE-25714 passed
+1 💚	compile	6m 30s	HBASE-25714 passed
+1 💚	checkstyle	2m 5s	HBASE-25714 passed
+1 💚	spotbugs	7m 44s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 40s	the patch passed
+1 💚	compile	6m 22s	the patch passed
+1 💚	cc	6m 22s	the patch passed
+1 💚	javac	6m 22s	the patch passed
-0 ⚠️	checkstyle	1m 7s	hbase-server: The patch generated 3 new + 225 unchanged - 2 fixed = 228 total (was 227)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	23m 10s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	hbaseprotoc	2m 54s	the patch passed
+1 💚	spotbugs	10m 53s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 42s	The patch does not generate ASF License warnings.
		81m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname	Linux 1e29d6d22e38 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/9/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/9/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

nyl3532016 · 2021-04-15T12:02:33Z

@Apache9 Would you help review it? Thanks

Apache-HBase · 2021-04-15T12:56:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 51s	HBASE-25714 passed
+1 💚	compile	6m 22s	HBASE-25714 passed
+1 💚	checkstyle	2m 8s	HBASE-25714 passed
+1 💚	spotbugs	7m 37s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 34s	the patch passed
+1 💚	compile	6m 17s	the patch passed
+1 💚	cc	6m 17s	the patch passed
+1 💚	javac	6m 17s	the patch passed
+1 💚	checkstyle	0m 10s	The patch passed checkstyle in hbase-protocol-shaded
+1 💚	checkstyle	0m 24s	The patch passed checkstyle in hbase-common
+1 💚	checkstyle	0m 27s	The patch passed checkstyle in hbase-client
+1 💚	checkstyle	1m 6s	hbase-server: The patch generated 0 new + 225 unchanged - 2 fixed = 225 total (was 227)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 58s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	hbaseprotoc	2m 27s	the patch passed
+1 💚	spotbugs	8m 10s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 50s	The patch does not generate ASF License warnings.
		70m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/10/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname	Linux faceed453b48 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/10/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-17T12:39:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 32s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 0s	HBASE-25714 passed
+1 💚	compile	6m 31s	HBASE-25714 passed
+1 💚	checkstyle	2m 14s	HBASE-25714 passed
+1 💚	spotbugs	7m 43s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 0s	the patch passed
+1 💚	compile	6m 23s	the patch passed
+1 💚	cc	6m 23s	the patch passed
+1 💚	javac	6m 23s	the patch passed
-0 ⚠️	checkstyle	1m 16s	hbase-server: The patch generated 1 new + 225 unchanged - 2 fixed = 226 total (was 227)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 49s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	hbaseprotoc	2m 25s	the patch passed
+1 💚	spotbugs	8m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 41s	The patch does not generate ASF License warnings.
		75m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/11/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname	Linux 696e0976810a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/11/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	87 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/11/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-17T14:31:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 36s	HBASE-25714 passed
+1 💚	compile	2m 37s	HBASE-25714 passed
+1 💚	shadedjars	7m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	HBASE-25714 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 40s	the patch passed
+1 💚	compile	2m 39s	the patch passed
+1 💚	javac	2m 39s	the patch passed
+1 💚	shadedjars	7m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 46s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 40s	hbase-common in the patch passed.
+1 💚	unit	1m 13s	hbase-client in the patch passed.
+1 💚	unit	148m 51s	hbase-server in the patch passed.
		187m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/11/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3115
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fef604053021 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `0242489`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/11/testReport/
Max. process+thread count	4722 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3115/11/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

nyl3532016 · 2021-04-18T02:02:15Z

precommit checks / yetus jdk11 hadoop3 checks failed due to workspace read only, I request a new PR

nyl3532016 force-pushed the HBASE-25715 branch from 6defbeb to ffab5c3 Compare April 1, 2021 12:53

nyl3532016 force-pushed the HBASE-25715 branch from ffab5c3 to 4c5017a Compare April 4, 2021 08:21

nyl3532016 requested review from Apache9, anoopsjohn, infraio, pankaj72981, saintstack and virajjasani April 4, 2021 08:23

Apache9 requested changes Apr 7, 2021

View reviewed changes

nyl3532016 force-pushed the HBASE-25715 branch 2 times, most recently from 33baad5 to a5ea930 Compare April 11, 2021 14:57

nyl3532016 force-pushed the HBASE-25715 branch from a5ea930 to b32b768 Compare April 12, 2021 02:45

HBASE-25715 Add a basic CompactionServer which only keep heartbeat wi…

d408eeb

…th HMaster

nyl3532016 force-pushed the HBASE-25715 branch from b32b768 to d408eeb Compare April 12, 2021 12:56

Apache9 requested changes Apr 12, 2021

View reviewed changes

abstract a method createMasterStub

ef0cf1a

some style amend

9534225

fix ut

213a939

nyl3532016 closed this Apr 18, 2021

Conversation

nyl3532016 commented Apr 1, 2021

Uh oh!

Apache-HBase commented Apr 1, 2021

Uh oh!

Apache-HBase commented Apr 1, 2021

Uh oh!

Apache-HBase commented Apr 1, 2021

Uh oh!

Apache-HBase commented Apr 1, 2021

Uh oh!

Apache-HBase commented Apr 1, 2021

Uh oh!

Apache-HBase commented Apr 1, 2021

Uh oh!

nyl3532016 commented Apr 4, 2021

Uh oh!

Apache-HBase commented Apr 4, 2021

Uh oh!

Apache-HBase commented Apr 4, 2021

Uh oh!

Apache-HBase commented Apr 4, 2021

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Apr 11, 2021

Uh oh!

Apache-HBase commented Apr 11, 2021

Uh oh!

Apache-HBase commented Apr 11, 2021

Uh oh!

Apache-HBase commented Apr 12, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Apr 12, 2021

Uh oh!

Apache-HBase commented Apr 14, 2021

Uh oh!

nyl3532016 commented Apr 15, 2021

Uh oh!

Apache-HBase commented Apr 15, 2021

Uh oh!

Apache-HBase commented Apr 17, 2021

Uh oh!

Apache-HBase commented Apr 17, 2021

Uh oh!

nyl3532016 commented Apr 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments