HBASE-26436 check-aggregate-license error related to javadns after HADOOP-17317 #3836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Tested with |
Member
Author
|
@apurtell do you want this back-ported to branch-2.4? It's relevant if we expect users to build against hadoop 3.4+ |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
jojochuang
approved these changes
Nov 10, 2021
|
🎊 +1 overall
This message was automatically generated. |
busbey
requested changes
Nov 10, 2021
Comment on lines
2262
to
2290
| <name>BSD 2-Clause License</name> | ||
| <url>https://opensource.org/licenses/BSD-2-Clause</url> | ||
| <distribution>repo</distribution> | ||
| <comments> | ||
| Copyright (c) 1998-2011, Brian Wellington. | ||
| </comments> |
Contributor
There was a problem hiding this comment.
the BSD 2 Clause license is not in the set of licenses where we aggregate all the dependencies provided with a single copy of the license text. (something that happens in hbase-resource-bundle/src/main/resources/META-INF/LICENSE.vm )
in such cases, we rely on the comments field here to provide the entirety of what we'll put into the generated LICENSE file. so this needs to include both this copyright statement and the complete text of the BSD 2 clause.
essentially everything from the LICENSE file on the dependency: https://github.com/dnsjava/dnsjava/blob/v3.4.0/LICENSE
it's the same kind of thing we had to do for jamon-runtime for the MPL.
ndimiduk
force-pushed
the
26436-javadns-license-aggregation
branch
from
6a9738d to
91c18c6
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
busbey
approved these changes
Nov 11, 2021
…DOOP-17317 Signed-off-by: Sean Busbey <busbey@apache.org> Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
ndimiduk
force-pushed
the
26436-javadns-license-aggregation
branch
from
91c18c6 to
f1dfee8
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.