Hbase-28014: Transient underlying HDFS failure causes permanent replciation failure between 2 HBase Clusters#5356
Open
tonyPan123 wants to merge 1 commit intoapache:branch-2.0from
Open
Conversation
…iation failure between 2 HBase Clusters
Contributor
|
Thanks for opening a PR. In HBase, we usually first open a PR against the master branch, and then cherry-pick to other branches. So please open a PR against master branch? Branch-2.0 has been EOL for a long time, I do not think the problem will only affect branch-2.0? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See HBase-28014 for details on the symptom and diagnostic.
The fix of HBase-28014 is implemented. In my local machine, it is able to pass all test cases.
I add some configurable retry mechanism to tolerate possible underlying HDFS failure.
Actually, I could add a unit test right now. However, I need to add a Fault Injector class to inject the IOException or override the replicationSourceManager and dynamically include the overriding one in the unit test. I am wondering if that would be a good convention.
Any comments and suggestions would be appreciated.