Skip to content

Hbase-28014: Transient underlying HDFS failure causes permanent replciation failure between 2 HBase Clusters #5356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tonyPan123 wants to merge 1 commit into
base: branch-2.0
Choose a base branch
from
Open

Hbase-28014: Transient underlying HDFS failure causes permanent replciation failure between 2 HBase Clusters #5356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .../main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ public class ReplicationSourceManager implements ReplicationListener {

private AtomicLong totalBufferUsed = new AtomicLong();

private int peerChangeMaxRetries;

/**
* Creates a replication manager and sets the watch on all the other registered region servers
* @param replicationQueues the interface for manipulating replication queues
Expand Down Expand Up @@ -172,6 +174,8 @@ public ReplicationSourceManager(ReplicationQueues replicationQueues,
this.latestPaths = new HashSet<Path>();
replicationForBulkLoadDataEnabled = conf.getBoolean(HConstants.REPLICATION_BULKLOAD_ENABLE_KEY,
HConstants.REPLICATION_BULKLOAD_ENABLE_DEFAULT);
this.peerChangeMaxRetries =
conf.getInt("replication.peer.change.max.try", 3);
}

/**
Expand Down Expand Up @@ -623,7 +627,17 @@ public void peerListChanged(List<String> peerIds) {
try {
boolean added = this.replicationPeers.peerConnected(id);
if (added) {
addSource(id);
int num_retries = 0;
while (num_retries < peerChangeMaxRetries) {
try {
addSource(id);
break;
} catch (IOException e) {
if (++num_retries == peerChangeMaxRetries) {
throw e;
}
}
}
if (replicationForBulkLoadDataEnabled) {
this.replicationQueues.addPeerToHFileRefs(id);
}
Expand Down