HBASE-30267 Backport HBASE-30266 Do not drop visibility delete marker…#8454
Merged
Merged
Conversation
liuxiaocs7
added
the
backport
There was a problem hiding this comment.
Pull request overview
Backports the fix for HBASE-30266/HBASE-30267 to ensure minor compaction on cell-visibility tables never drops visibility delete markers as “redundant,” preventing potential resurrection of data that should remain deleted.
Changes:
- Override
VisibilityScanDeleteTracker#isRedundantDeleteto always returnfalsefor visibility tables. - Add focused unit tests asserting no delete marker is considered redundant under visibility tracking.
- Add an end-to-end regression test covering minor-compaction behavior with differently-labeled
DeleteColumnmarkers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java | Ensures delete markers are never treated as redundant under visibility semantics to avoid incorrect dropping during minor compaction. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityScanDeleteTracker.java | Adds unit coverage for the conservative “never redundant” contract across label variants. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java | Adds an end-to-end regression test verifying minor compaction does not drop differently-labeled delete markers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…s as redundant during minor compaction to branch-2 (apache#8448) Signed-off-by: Junegunn Choi <junegunn@apache.org> (cherry picked from commit 3d93aa2)
liuxiaocs7
force-pushed
the
HBASE-30267-branch-2.6
branch
from
b7c9dba to
507ff05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s as redundant during minor compaction to branch-2 (#8448)
Signed-off-by: Junegunn Choi junegunn@apache.org
(cherry picked from commit 3d93aa2)