Skip to content

HBASE-29733 Use ServerName instead of hostname in unloadRegions log m… #8455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guluo2016 merged 1 commit into from
Jul 7, 2026
+9 −8
Merged

HBASE-29733 Use ServerName instead of hostname in unloadRegions log m… #8455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,8 +583,8 @@ private void unloadRegions(ServerName server, List<ServerName> regionServers,
isolateRegionInfo = hRegionLocation.getRegion();
isolateRegionInfoList.add(isolateRegionInfo);
if (hRegionLocation.getServerName() == server) {
LOG.info("Region " + hRegionLocation.getRegion().getEncodedName() + " already exists"
+ " on server : " + server.getHostname());
LOG.info("Region {} already exists on server: {}",
hRegionLocation.getRegion().getEncodedName(), server);
} else {
Future<Boolean> isolateRegionTask =
isolateRegionPool.submit(new MoveWithAck(conn, isolateRegionInfo,
Expand All @@ -608,14 +608,14 @@ private void unloadRegions(ServerName server, List<ServerName> regionServers,
break;
}
} else {
LOG.info("All regions already exists on server : " + server.getHostname());
LOG.info("All regions already exists on server: {}", server);
}
// Once region has been moved to target RS, put the target RS into decommission mode,
// so master doesn't assign new region to the target RS while we unload the target RS.
// Also pass 'offload' flag as false since we don't want master to offload the target RS.
List<ServerName> listOfServer = new ArrayList<>();
listOfServer.add(server);
LOG.info("Putting server : " + server.getHostname() + " in decommission/draining mode");
LOG.info("Putting server: {} in decommission/draining mode", server);
admin.decommissionRegionServers(listOfServer, false);
}
List<RegionInfo> regionsToMove = admin.getRegions(server);
Expand All @@ -628,7 +628,7 @@ private void unloadRegions(ServerName server, List<ServerName> regionServers,
break;
}
LOG.info("Moving {} regions from {} to {} servers using {} threads .Ack Mode: {}",
regionsToMove.size(), this.hostname, regionServers.size(), this.maxthreads, ack);
regionsToMove.size(), server, regionServers.size(), this.maxthreads, ack);

Optional<RegionInfo> metaRegion = getMetaRegionInfoIfToBeMoved(regionsToMove);
if (metaRegion.isPresent()) {
Expand Down Expand Up @@ -684,10 +684,11 @@ private boolean waitTaskToFinish(ExecutorService pool, Future<Boolean> task, Str
try {
return task.get(5, TimeUnit.SECONDS);
} catch (InterruptedException e) {
LOG.warn("Interrupted while " + operation + " Regions on " + this.hostname, e);
LOG.warn("Interrupted while {} regions on {}:{}", operation, this.hostname, this.port, e);
throw e;
} catch (ExecutionException e) {
LOG.error("Error while " + operation + " regions on RegionServer " + this.hostname, e);
LOG.error("Error while {} regions on RegionServer {}:{}", operation, this.hostname, this.port,
e);
throw e;
}
}
Expand Down Expand Up @@ -852,7 +853,7 @@ private void includeExcludeRegionServers(String fileName, List<ServerName> regio
if (fileName != null) {
List<String> servers = readServersFromFile(fileName);
if (servers.isEmpty()) {
LOG.warn("No servers provided in the file: {}." + fileName);
LOG.warn("No servers provided in the file: {}.", fileName);
return;
}
Iterator<ServerName> i = regionServers.iterator();
Expand Down
Loading