HBASE-29710 Skip normalization when tableRegions contains overlaps/holes#8472
Open
SwaraliJoshi wants to merge 1 commit into
Open
HBASE-29710 Skip normalization when tableRegions contains overlaps/holes#8472SwaraliJoshi wants to merge 1 commit into
SwaraliJoshi wants to merge 1 commit into
Conversation
Splitting/merging a table whose region chain already has holes or overlaps can increase the number of holes/overlaps and complicate the eventual repair by the CatalogJanitor/HBCK. The merge path is protected downstream by MergeTableRegionsProcedure (force=false rejects non-adjacent/non-overlapping regions), but the split path had no such guard. Add a scheduler-level check in SimpleRegionNormalizer that scans the sorted region chain for a hole, overlap, or degenerate region and skips normalization (both split and merge) for that table when the chain is broken. Guarded by a new config toggle hbase.normalizer.skip.broken.chain (default true, documented in hbase-default.xml) and emits a WARN log naming the offending region pair. The merge-side validation is left untouched. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting/merging a table whose region chain already has holes or overlaps can increase the number of holes/overlaps and complicate the eventual repair by the CatalogJanitor/HBCK. The merge path is protected downstream by MergeTableRegionsProcedure (force=false rejects non-adjacent/non-overlapping regions), but the split path had no such guard.
Add a scheduler-level check in SimpleRegionNormalizer that scans the sorted region chain for a hole, overlap, or degenerate region and skips normalization (both split and merge) for that table when the chain is broken. Guarded by a new config toggle hbase.normalizer.skip.broken.chain (default true, documented in hbase-default.xml) and emits a WARN log naming the offending region pair. The merge-side validation is left untouched.