Skip to content

HIVE-28081: Code refine on ClearDanglingScratchDir::removeLocalTmpFiles #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhangbutao merged 1 commit into from
Feb 21, 2024
Merged

HIVE-28081: Code refine on ClearDanglingScratchDir::removeLocalTmpFiles #5090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions ql/src/java/org/apache/hadoop/hive/ql/session/ClearDanglingScratchDir.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,17 +252,12 @@ static Options createOptions() {
*/
private void removeLocalTmpFiles(String sessionName, String localTmpdir) {
File[] files = new File(localTmpdir).listFiles(fn -> fn.getName().startsWith(sessionName));
boolean success;
if (files != null) {
Comment thread
zhangbutao marked this conversation as resolved.
for (File file : files) {
success = false;
if (file.canWrite()) {
success = file.delete();
}
if (success) {
if (file.canWrite() && file.delete()) {
consoleMessage("While removing '" + sessionName + "' dangling scratch dir from HDFS, "
+ "local tmp session file '" + file.getPath() + "' has been cleaned as well.");
} else if (file.getName().startsWith(sessionName)) {

@zhangbutao zhangbutao Feb 19, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Line 254, file in here is already startsWith(sessionName), so no need check this again.

} else {
consoleMessage("Even though '" + sessionName + "' is marked as dangling session dir, "
+ "local tmp session file '" + file.getPath() + "' could not be removed.");
}
Expand Down