refactor(hadoop-common): use SLF4J parameterized logging instead of string concatenation#19160
Merged
voonhous merged 1 commit intoJul 4, 2026
Conversation
…tring concatenation
Convert log/LOG string concatenation to {} placeholders across
hudi-hadoop-common (main + tests). Mechanical and behavior-preserving;
the trailing throwable in HoodieParquetFileBinaryCopier stays the last
arg so its stacktrace is logged as before.
voonhous
changed the title
hudi-agent
reviewed
Jul 3, 2026
hudi-agent
left a comment
hudi-agent
left a comment
Contributor
There was a problem hiding this comment.
No issues flagged.
cc @yihua
Collaborator
wombatu-kun
approved these changes
Jul 4, 2026
This was referenced Jul 4, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
A number of
log/LOGcalls inhudi-hadoop-commonbuild their message with+string concatenation. This eagerly builds the string even when the level is disabled and reads worse than a parameterized statement. This PR converts them to SLF4J{}templating. Part of the ongoing logging cleanup (follows #19155, #19156, #19157, #19158, #19159).Summary and Changelog
log/LOGcalls to{}placeholders acrosshudi-hadoop-common(main + tests). Mechanical and behavior-preserving.HoodieParquetFileBinaryCopier: the trailingestays the throwable arg, so its stacktrace is logged as before.Impact
none - purely mechanical, behavior-preserving logging change.
Risk Level
none
Documentation Update
none
Note: a couple of files still use plain
LoggerFactory.getLoggerLOGfields. Migrating those to the Lombok@Slf4jannotation will be done in a separate round of cleanup sweeps; this PR only covers the concatenation-to-templating conversion.Contributor's checklist