refactor(sync): use SLF4J parameterized logging instead of string concatenation#19189
Merged
voonhous merged 1 commit intoJul 5, 2026
Merged
Conversation
…catenation
Convert log string concatenation to {} placeholders in HiveSyncTool and
QueryBasedDDLExecutor. Mechanical and behavior-preserving.
voonhous
changed the title
hudi-agent
reviewed
Jul 4, 2026
hudi-agent
left a comment
hudi-agent
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! This PR mechanically converts string-concatenation log calls to SLF4J parameterized logging in HiveSyncTool and QueryBasedDDLExecutor. The placeholder counts match the argument counts in each converted statement, and the changes are behavior-preserving. No issues flagged from this automated pass, and a Hudi committer or PMC member can take it from here for a final review.
cc @yihua
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
A number of
logcalls inhudi-syncbuild their message with+string concatenation. This eagerly builds the string even when the level is disabled and reads worse than a parameterized statement. This PR converts them to SLF4J{}templating. Part of the ongoing logging cleanup (follows #19155, #19156, #19157, #19158, #19159, #19160, #19184, #19185, #19186, #19187, #19188).Summary and Changelog
logcalls to{}placeholders inHiveSyncToolandQueryBasedDDLExecutor(hudi-hive-sync). Mechanical and behavior-preserving.Impact
none - purely mechanical, behavior-preserving logging change.
Risk Level
none
Documentation Update
none
Contributor's checklist