Skip to content

refactor(sync): use SLF4J parameterized logging instead of string concatenation #19189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
voonhous merged 1 commit into from
Jul 5, 2026
+3 −3
Merged

refactor(sync): use SLF4J parameterized logging instead of string concatenation #19189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ private boolean syncPartitions(String tableName, List<PartitionEvent> partitionE

List<String> touchPartitions = config.getBoolean(META_SYNC_TOUCH_PARTITIONS_ENABLED) ? filterPartitions(partitionEventList, PartitionEventType.TOUCH) : Collections.emptyList();
if (!touchPartitions.isEmpty()) {
log.info("Touch Partitions " + touchPartitions);
log.info("Touch Partitions {}", touchPartitions);
syncClient.touchPartitionsToTable(tableName, touchPartitions);
}

Expand Down
4 changes: 2 additions & 2 deletions hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/QueryBasedDDLExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,10 +205,10 @@ public String getPartitionClause(String partition) {
@Override
public void touchPartitionsToTable(String tableName, List<String> touchPartitions) {
if (touchPartitions.isEmpty()) {
log.info("No partitions to touch for " + tableName);
log.info("No partitions to touch for {}", tableName);
return;
}
log.info("Touching partitions " + touchPartitions.size() + " on " + tableName);
log.info("Touching partitions {} on {}", touchPartitions.size(), tableName);
List<String> sqls = constructPartitionAlterStatements(tableName, touchPartitions, PartitionAlterType.TOUCH);
for (String sql : sqls) {
runSQL(sql);
Expand Down
Loading