Skip to content

Conversation

@liuruiyiyang
Copy link
Contributor

@liuruiyiyang liuruiyiyang commented Jan 20, 2019

  1. Use thread to call outputStream.force periodically to solve WAL perf issue. See https://issues.apache.org/jira/browse/IOTDB-4
  2. Add a new parameter forceWalPeriodInMs
  3. Remove redundant parameter wal_cleanup_threshold

Copy link
Member

@jixuan1989 jixuan1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments on MultiFileLogNodeManager.java

@liuruiyiyang liuruiyiyang changed the title Force in thread periodically [IOTDB-4] Force WAL in thread periodically Jan 21, 2019
Copy link
Member

@jixuan1989 jixuan1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems no obvious issues. Look forward to read the performance improvement report.

@liuruiyiyang
Copy link
Contributor Author

The comparison report is uploaded to JIRA see https://issues.apache.org/jira/browse/IOTDB-4 , here is a quick look:
image
@jixuan1989

@jixuan1989 jixuan1989 merged commit eb922ea into master Jan 21, 2019
@jixuan1989 jixuan1989 deleted the force-in-thread-periodically branch January 21, 2019 06:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mzp0514 pushed a commit to mzp0514/iotdb that referenced this pull request Apr 26, 2021
# This is the 1st commit message:

Fix query one sensor in a vector from memtable (apache#3056)

Fix query one sensor in a vector from memtable
# This is the commit message apache#2:

[IOTDB-1310] Enable docker, docker-compose and testcontainer for End to end test (apache#3024)

* enable TestCongtainer for E2E test for (singleNode and cluster)

* remove duplicated operations in integration-test phase

* move spotless:apply to a profile `spotless`, which is enabled by default.

Co-authored-by: xiangdong huang <sainthxd@gmail.com>
# This is the commit message apache#3:

add sink interface

# This is the commit message apache#4:

3 new event sinks

# This is the commit message apache#5:

add ts sink

# This is the commit message apache#6:

add ts sink

# This is the commit message apache#7:

add mqtt sink

# This is the commit message apache#8:

refactor sink module

# This is the commit message apache#9:

init package sink.manager

# This is the commit message apache#10:

rename SinkException

# This is the commit message apache#11:

remove id in config

# This is the commit message apache#12:

fix doc

# This is the commit message apache#13:

add test framework

# This is the commit message apache#14:

add alertmanager sink & test & doc

# This is the commit message apache#15:

beautify the doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants