[IOTDB-5]fundamental classes for supporting deletion #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wujysh
suggested changes
Jan 20, 2019
Contributor
wujysh
left a comment
wujysh
left a comment
There was a problem hiding this comment.
Perhaps we should not paste private links on Apache repository. It is not friendly for the public open source community.
iotdb/src/main/java/org/apache/iotdb/db/engine/modification/package-info.java
Outdated
Show resolved
Hide resolved
Contributor
|
LGTM except the PR title. Can you change to a more clear one? |
Contributor
Author
|
I may try, though I am bad at naming. |
jt2594838
changed the title
Member
|
I think it's better to open an issue(include description, implementation, documents, etc) in jira. All pull requests should be associated in this issue. |
jt2594838
changed the title
qiaojialin
requested changes
Feb 2, 2019
iotdb/src/main/java/org/apache/iotdb/db/engine/modification/Deletion.java
Outdated
Show resolved
Hide resolved
iotdb/src/main/java/org/apache/iotdb/db/engine/modification/Modification.java
Outdated
Show resolved
Hide resolved
jixuan1989
reviewed
Feb 14, 2019
| */ | ||
| public void close() throws IOException { | ||
| synchronized (this) { | ||
| writer.close(); |
Member
There was a problem hiding this comment.
you need to call reader.close() here. Otherwise please set reader.close() as a private function
Contributor
Author
There was a problem hiding this comment.
reader and writer refer to the same object in this implementation, so there is no need to close reader after writer is closed.
jixuan1989
reviewed
Feb 15, 2019
.../src/main/java/org/apache/iotdb/db/engine/modification/io/LocalTextModificationAccessor.java
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed.
|
mychaow
pushed a commit
to mychaow/incubator-iotdb
that referenced
this pull request
Dec 31, 2020
mzp0514
pushed a commit
to mzp0514/iotdb
that referenced
this pull request
Apr 26, 2021
# This is the 1st commit message: Fix query one sensor in a vector from memtable (apache#3056) Fix query one sensor in a vector from memtable # This is the commit message apache#2: [IOTDB-1310] Enable docker, docker-compose and testcontainer for End to end test (apache#3024) * enable TestCongtainer for E2E test for (singleNode and cluster) * remove duplicated operations in integration-test phase * move spotless:apply to a profile `spotless`, which is enabled by default. Co-authored-by: xiangdong huang <sainthxd@gmail.com> # This is the commit message apache#3: add sink interface # This is the commit message apache#4: 3 new event sinks # This is the commit message apache#5: add ts sink # This is the commit message apache#6: add ts sink # This is the commit message apache#7: add mqtt sink # This is the commit message apache#8: refactor sink module # This is the commit message apache#9: init package sink.manager # This is the commit message apache#10: rename SinkException # This is the commit message apache#11: remove id in config # This is the commit message apache#12: fix doc # This is the commit message apache#13: add test framework # This is the commit message apache#14: add alertmanager sink & test & doc # This is the commit message apache#15: beautify the doc
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fundamental classes for supporting deletion.