[IOTDB-5]Embedding modifications in querying #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # iotdb/src/test/java/org/apache/iotdb/db/engine/bufferwrite/BufferWriteProcessorNewTest.java # iotdb/src/test/java/org/apache/iotdb/db/engine/bufferwrite/BufferWriteProcessorTest.java
# Conflicts: # iotdb/src/main/java/org/apache/iotdb/db/qp/strategy/PhysicalGenerator.java # iotdb/src/main/java/org/apache/iotdb/db/query/reader/sequence/SealedTsFilesReader.java
Beyyes
requested changes
Jan 24, 2019
| measurementSchema.getType(), measurementSchema.getEncodingType(), statistics, 0, 0, 0, 0); | ||
| writer.endChunk(0); | ||
| ChunkGroupFooter footer = new ChunkGroupFooter(deviceId, 0, 1); | ||
| writer.endChunkGroup(footer); |
Member
There was a problem hiding this comment.
Is there exist any tests for TsFile?
Contributor
Author
There was a problem hiding this comment.
No, the changes to TsFile are minimal, and those changes are covered by tests in IoTDB.
tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/TsFileIOWriter.java
Outdated
Show resolved
Hide resolved
| **/ | ||
| private long recordCountForNextMemCheck = 100; | ||
| private long chunkGroupSizeThreshold; | ||
| private long version = 0; |
Member
There was a problem hiding this comment.
I think you can add some comments about the version.
Although there is no comments for recordCountForNextMemCheck and chunkGroupSizeThreshold.
Contributor
Author
There was a problem hiding this comment.
Added, though it is hard to explain a few words.
tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/series/FileSeriesReader.java
Outdated
Show resolved
Hide resolved
| switch (dataType) { | ||
| case BOOLEAN: | ||
| pageData.putBoolean(valueDecoder.readBoolean(valueBuffer)); | ||
| boolean aBoolean = valueDecoder.readBoolean(valueBuffer); |
Member
There was a problem hiding this comment.
I think we should take these examination type code (boolean, int32, int64, float, double, etc) into single methods.
Maybe we can do it after the fix_sonar pr.
Contributor
Author
There was a problem hiding this comment.
Yeah，I've seen that PR and I will leave this to later merge.
iotdb/src/test/java/org/apache/iotdb/db/integration/IoTDBDeletionTest.java
Outdated
Show resolved
Hide resolved
iotdb/src/test/java/org/apache/iotdb/db/integration/IoTDBDeletionTest.java
Outdated
Show resolved
Hide resolved
iotdb/src/test/java/org/apache/iotdb/db/integration/IoTDBDeletionTest.java
Outdated
Show resolved
Hide resolved
iotdb/src/test/java/org/apache/iotdb/db/integration/IoTDBDeletionTest.java
Outdated
Show resolved
Hide resolved
iotdb/src/test/java/org/apache/iotdb/db/engine/version/SimpleFileVersionControllerTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # iotdb/src/main/java/org/apache/iotdb/db/engine/filenode/FileNodeProcessor.java # iotdb/src/main/java/org/apache/iotdb/db/engine/overflow/ioV2/OverflowResource.java # iotdb/src/main/java/org/apache/iotdb/db/engine/overflow/ioV2/OverflowSupport.java
# Conflicts: # tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/chunk/ChunkReaderWithFilter.java # tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/chunk/ChunkReaderWithoutFilter.java # tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/page/PageReader.java
fix some uts with incorrect answers
mzp0514
pushed a commit
to mzp0514/iotdb
that referenced
this pull request
Apr 26, 2021
# This is the 1st commit message: Fix query one sensor in a vector from memtable (apache#3056) Fix query one sensor in a vector from memtable # This is the commit message apache#2: [IOTDB-1310] Enable docker, docker-compose and testcontainer for End to end test (apache#3024) * enable TestCongtainer for E2E test for (singleNode and cluster) * remove duplicated operations in integration-test phase * move spotless:apply to a profile `spotless`, which is enabled by default. Co-authored-by: xiangdong huang <sainthxd@gmail.com> # This is the commit message apache#3: add sink interface # This is the commit message apache#4: 3 new event sinks # This is the commit message apache#5: add ts sink # This is the commit message apache#6: add ts sink # This is the commit message apache#7: add mqtt sink # This is the commit message apache#8: refactor sink module # This is the commit message apache#9: init package sink.manager # This is the commit message apache#10: rename SinkException # This is the commit message apache#11: remove id in config # This is the commit message apache#12: fix doc # This is the commit message apache#13: add test framework # This is the commit message apache#14: add alertmanager sink & test & doc # This is the commit message apache#15: beautify the doc
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use modifications as filters to remove deleted data during query processing.