KAFKA-20553 Eliminate the dependencies on sourceSets.test.output for group-coordinator and share-coordinator#22254
Merged
Conversation
github-actions
Bot
added
triage
chia7712
changed the title
chia7712
changed the title
chia7712
approved these changes
May 11, 2026
| testImplementation project(':group-coordinator').sourceSets.test.output | ||
| testImplementation project(':share-coordinator').sourceSets.test.output | ||
| testImplementation testFixtures(project(':group-coordinator')) | ||
| testImplementation testFixtures(project(':share-coordinator')) |
Member
There was a problem hiding this comment.
Currently, the core module relies on ShareCoordinatorTestConfig for its integration tests. Since these ITs will eventually be migrated to the server module, extracting the config into testFixtures is a forward-looking and solid design choice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle test fixtures to the clients module and removes all dependencies
on sourceSets.test.output. We should revisit other usages in this JIRA.
This will simplify the dependency graph and unblock the upgrade to
Gradle 9.5+
This patch is working on
group-coordinatorandshare-coordinatorReviewers: Chia-Ping Tsai chia7712@gmail.com