Skip to content

KAFKA-20553 Eliminate the dependencies on sourceSets.test.output for group-coordinator and share-coordinator #22254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 1 commit into from
May 12, 2026
+15 −2
Merged

KAFKA-20553 Eliminate the dependencies on sourceSets.test.output for group-coordinator and share-coordinator #22254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,8 +1139,8 @@ project(':core') {
implementation libs.re2j

testImplementation testFixtures(project(':clients'))
testImplementation project(':group-coordinator').sourceSets.test.output
testImplementation project(':share-coordinator').sourceSets.test.output
testImplementation testFixtures(project(':group-coordinator'))
testImplementation testFixtures(project(':share-coordinator'))
Copy link
Copy Markdown
Member

@chia7712 chia7712 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the core module relies on ShareCoordinatorTestConfig for its integration tests. Since these ITs will eventually be migrated to the server module, extracting the config into testFixtures is a forward-looking and solid design choice

testImplementation project(':metadata').sourceSets.test.output
testImplementation project(':raft').sourceSets.test.output
testImplementation testFixtures(project(':server-common'))
Expand Down Expand Up @@ -1520,6 +1520,8 @@ project(':group-coordinator') {
archivesName = "kafka-group-coordinator"
}

apply plugin: 'java-test-fixtures'

configurations {
generator
}
Expand All @@ -1539,6 +1541,11 @@ project(':group-coordinator') {
implementation libs.slf4jApi
implementation libs.hash4j

testFixturesImplementation project(':clients')
testFixturesImplementation project(':coordinator-common')
testFixturesImplementation project(':server-common')
testFixturesImplementation libs.junitJupiter

testImplementation testFixtures(project(':clients'))
testImplementation testFixtures(project(':server-common'))
testImplementation project(':coordinator-common').sourceSets.test.output
Expand Down Expand Up @@ -1791,6 +1798,8 @@ project(':share-coordinator') {
archivesName = "kafka-share-coordinator"
}

apply plugin: 'java-test-fixtures'

configurations {
generator
}
Expand All @@ -1804,6 +1813,8 @@ project(':share-coordinator') {
implementation libs.metrics
implementation libs.slf4jApi

testFixturesImplementation project(':clients')

testImplementation testFixtures(project(':clients'))
testImplementation testFixtures(project(':server-common'))
testImplementation project(':coordinator-common').sourceSets.test.output
Expand Down Expand Up @@ -4075,6 +4086,8 @@ gradle.projectsEvaluated {
'clients': ':clients',
'server-common': ':server-common',
'storage/api': ':storage:storage-api',
'group-coordinator': ':group-coordinator',
'share-coordinator': ':share-coordinator',
]
allprojects { proj ->
proj.configurations.all { config ->
Expand Down
0 ...e/kafka/coordinator/group/Assertions.java → ...e/kafka/coordinator/group/Assertions.java
View file
Open in desktop
File renamed without changes.
0 ...tor/share/ShareCoordinatorTestConfig.java → ...tor/share/ShareCoordinatorTestConfig.java
View file
Open in desktop
File renamed without changes.
Loading