MINOR: Re-read PRODUCE throttle metric each iteration in produceUntilThrottled#22332
Closed
nileshkumar3 wants to merge 1 commit into
Closed
MINOR: Re-read PRODUCE throttle metric each iteration in produceUntilThrottled#22332nileshkumar3 wants to merge 1 commit into
nileshkumar3 wants to merge 1 commit into
Conversation
github-actions
Bot
added
core
Contributor
Author
|
Addressed the issue here with other changes #22338 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing the PR #22329, I noticed that produceUntilThrottled caches the produce throttle metric reference before entering the polling loop.
Since the broker registers the throttle metric lazily, the metric may not yet exist when the helper first reads it. In that case, the cached reference remains null for the lifetime of the method, preventing the helper from observing throttling even after the broker later records the metric.
Reviewer - @muralibasani