KAFKA-8073: Fix flaky BaseQuotaTest.testThrottledProducerConsumer#22338
Open
nileshkumar3 wants to merge 2 commits into
Open
KAFKA-8073: Fix flaky BaseQuotaTest.testThrottledProducerConsumer#22338nileshkumar3 wants to merge 2 commits into
nileshkumar3 wants to merge 2 commits into
Conversation
Contributor
|
@nileshkumar3 can you pls add some loop(may be 50) run results executed locally ? this could help if the flakiness is gone. |
Contributor
Author
|
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://issues.apache.org/jira/browse/KAFKA-8073
Causes
produceUntilThrottledsent tiny payloads, so on slow hosts the1000 sends could stay under the 8000 B/s producer quota and never
trigger a throttle.
throttle-timemetric was cached once before the sendloop, so the lazily-registered sensor could be missed.
verifyThrottleTimeRequestChannelMetricasserted on the brokerThrottleTimeMshistogram immediately, before the broker hadrecorded the value.
Changes
produceUntilThrottledso the quota isreliably exceeded.
ThrottleTimeMsviaTestUtils.waitUntilTrue.