Sync 2 recent commits to 4.3#22656
Closed
dongnuo123 wants to merge 2 commits into
Closed
Conversation
…on in group coordinator (apache#22264) The `deserialize*` methods in `ConsumerProtocol` only catch `BufferUnderflowException` and re-wrap it as `SchemaException`. Malformed bytes can also surface as other `RuntimeException`s (e.g. `IllegalArgumentException` from negative array lengths in `ByteBufferAccessor`), which escape these methods. Callers that only guard against `SchemaException` then propagate the failure, which can destabilize the group coordinator. ### Changes In `ConsumerProtocol`, broaden the `catch` clause from `BufferUnderflowException` to `RuntimeException` in all four deserialization entry points, re-wrapping as `SchemaException`: - `deserializeSubscription` - `deserializeConsumerProtocolSubscription` - `deserializeAssignment` - `deserializeConsumerProtocolAssignment` Reviewers: Sean Quah <squah@confluent.io>, David Jacot <david.jacot@gmail.com>
…t during online migration (apache#22580) When the subscription deserialization fails, we throw an IllegalStateException ``` private static ConsumerProtocolSubscription deserializeSubscription( JoinGroupRequestProtocolCollection protocols ) { try { return ConsumerProtocol.deserializeConsumerProtocolSubscription( ByteBuffer.wrap(protocols.iterator().next().metadata())); } catch (SchemaException e) { throw new IllegalStateException("Malformed embedded consumer protocol in subscription deserialization."); } } ``` which will be translated to UNKNOWN_SERVER_ERROR. This is a bit confusing to the client. We throw a fatal `INCONSISTENT_GROUP_PROTOCOL` here instead. Reviewers: David Jacot <david.jacot@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync the 2 recent commits to 4.3