MINOR: Fix ShareGroupCommandTest reset-offsets tests passing invalid --from-file scope combination#22679
Merged
AndrewJSchofield merged 1 commit intoJun 26, 2026
Conversation
AndrewJSchofield
approved these changes
Jun 26, 2026
AndrewJSchofield
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests from #22197 combined
--from-filewith--topic/--all-topics,whichShareGroupCommandOptions.checkArgsforbids —
allResetOffsetsScopeOptsmakes{--topic, --all-topics, --from-file}mutually exclusive, enforced viacheckInvalidArgs. Thetests only passed because a leaked no-op
Exitprocedure swallowed theresulting
printUsageAndExit. - Drop--topic/--all-topicsfromboth tests' import args so
--from-fileis the sole scope. - AdjustdescribeTopicscount 6 → 5 intestResetOffsetsExportImportPlan(no--topicmeans partitions come fromlistShareGroupOffsets).Test-only; no production changes.
Reviewers: Andrew Schofield aschofield@confluent.io