Skip to content

MINOR: Fix ShareGroupCommandTest reset-offsets tests passing invalid --from-file scope combination#22679

Merged
AndrewJSchofield merged 1 commit into
apache:trunkfrom
joshua2519:minor-fix-ShareGroupCommandTest
Jun 26, 2026
Merged

MINOR: Fix ShareGroupCommandTest reset-offsets tests passing invalid --from-file scope combination#22679
AndrewJSchofield merged 1 commit into
apache:trunkfrom
joshua2519:minor-fix-ShareGroupCommandTest

Conversation

@joshua2519

@joshua2519 joshua2519 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Two tests from #22197 combined --from-file with
--topic/--all-topics,which ShareGroupCommandOptions.checkArgs
forbids — allResetOffsetsScopeOpts makes {--topic, --all-topics, --from-file} mutually exclusive, enforced via checkInvalidArgs. The
tests only passed because a leaked no-op Exit procedure swallowed the
resulting printUsageAndExit. - Drop --topic/--all-topics from
both tests' import args so --from-file is the sole scope. - Adjust
describeTopics count 6 → 5 in testResetOffsetsExportImportPlan (no
--topic means partitions come from listShareGroupOffsets).

Test-only; no production changes.

Reviewers: Andrew Schofield aschofield@confluent.io

@github-actions github-actions Bot added triage PRs from the community tools tests Test fixes (including flaky tests) small Small PRs labels Jun 26, 2026

@AndrewJSchofield AndrewJSchofield left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. lgtm

@AndrewJSchofield
AndrewJSchofield merged commit 980913a into apache:trunk Jun 26, 2026
24 checks passed
@github-actions github-actions Bot removed the triage PRs from the community label Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved small Small PRs tests Test fixes (including flaky tests) tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants