KAFKA-10369: Add TimestampAndOffset value type of deduplication store (1/N)#22820
Open
AyoubOm wants to merge 1 commit into
Open
KAFKA-10369: Add TimestampAndOffset value type of deduplication store (1/N)#22820AyoubOm wants to merge 1 commit into
AyoubOm wants to merge 1 commit into
Conversation
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a first PR for adding deduplication operator to Streams DSL. See this global PR draft for reference #22189
This PR adds the TimestampAndOffset class which will be used as a the value type of the deduplication store. The store keeps track of the records seen so far, and will be used by the processor to deduplicate records. See wiki and mail thread discussion for the reason we need the timestamp and offset.
In brief:
Deduplication is bounded in time and the store doesn't keep records forever - old records should be evicted from the store => Hence Timestamp
Records may be processed twice in case of a failure - we need to track records that have been saved in the store and still not committed => Hence Offset
JIRA
KAFKA-10369