MINOR: Move JaasModule into JaasUtils#22867
Merged
chia7712 merged 2 commits intoJul 19, 2026
Merged
Conversation
chia7712
reviewed
Jul 18, 2026
| public class JaasUtils { | ||
| public record JaasModule(String name, boolean debug, Map<String, String> entries) { | ||
|
|
||
| public static JaasModule plainLoginModule(String username, String password, boolean debug, Map<String, String> validUsers) { |
Member
There was a problem hiding this comment.
Do you like JaasUtils.JaasModule.plainLoginModule? If not, could you move plainLoginModule out of JaasModule scope?
Contributor
Author
There was a problem hiding this comment.
JaasUtils.plainLoginModule is clearer. I’ll move the factory method out of the nested JaasModule scope.
Contributor
Author
|
I moved |
chia7712
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
JaasModuleintoJaasUtilsas a nested record,alongside
JaasSection.It also updates
KafkaClusterTestKitto reference the nestedJaasUtils.JaasModuletype and removes the standaloneJaasModule.javafile.
This is a code organization change with no intended behavior change.
Testing
Reviewers: Chia-Ping Tsai chia7712@gmail.com