KAFKA-20815: Remove unnecessary jline deps and bump to latest 3.x#22898
Merged
Conversation
github-actions
Bot
added
triage
mimaison
reviewed
Jul 21, 2026
| BSD 3-Clause | ||
|
|
||
| - jline-3.30.4, see: licenses/jline-BSD-3-clause | ||
| - jline-3.30.15, see: licenses/jline-BSD-3-clause |
Member
There was a problem hiding this comment.
This must contain the names of the JARs we ship. So we need:
- jline-native-3.30.15
- jline-reader-3.30.15
- jline-terminal-3.30.15
Contributor
Author
There was a problem hiding this comment.
Thanks I fixed it in 1398ee4 and also verified it with the committer-tools/verify_license.py script
… removing the old jline bundle
chia7712
reviewed
Jul 22, 2026
| jersey: "3.1.10", | ||
| jgit: "7.6.0.202603022253-r", | ||
| jline: "3.30.4", | ||
| jline: "3.30.15", |
Member
There was a problem hiding this comment.
3.30.16 was just released, and we just missed the bus 😆
Member
There was a problem hiding this comment.
@harmadasg do you have time to file a patch so we can catch the next bus?
Contributor
Author
mimaison
pushed a commit
that referenced
this pull request
Jul 22, 2026
See [KAFKA-20815](https://issues.apache.org/jira/browse/KAFKA-20815) and #22898 (comment) Reviewers: Ken Huang <s7133700@gmail.com>, Mickael Maison <mickael.maison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KAFKA-20815 reported a security vulnerability on
jline-remote-telnet3.30.4. Kafka does not have a dependency on the mentioned package but
actually uses the whole jline bundle which includes telnet related
binaries too. Jline is only used for the metadata shell module which in
turn only needs it for basic terminal functionality, there are no remote
capabilities. This PR aims to remove the unnecessary jline dependencies
and prevent false positive security vulnerability scan results about
jline telnet/ssh.
The shell module only needs the
jline-readerdependency which alsopulls in transitive dependencies
jline-terminalandjline -native.As an additional benefit the change reduces binary size going from jline
bunde (1.40 MB) to jline-reader + jline-terminal + jline-native (650 KB)
~ 55% saved
While at it the dependency version has been updated to the latest 3.x
release
Reviewers: Mickael Maison mickael.maison@gmail.com