MINOR: Cleanup build.gradle unused dependency - #22903
Merged
Merged
Conversation
github-actions
Bot
added
triage
m1a2st
force-pushed
the
MINOR-cleanup-gradle
branch
from
July 22, 2026 03:06
7437d04 to
54683a3
Compare
m1a2st
changed the title
m1a2st
changed the title
chia7712
reviewed
Jul 22, 2026
| apply plugin: 'java-test-fixtures' | ||
|
|
||
| dependencies { | ||
| compileOnly libs.bndlib |
Member
There was a problem hiding this comment.
It seems no module depends on bndlib, right?
Member
There was a problem hiding this comment.
reference: #17373 (comment)
In short, we can remove it safely :)
Collaborator
Author
There was a problem hiding this comment.
Yes, I have addressed this
chia7712
reviewed
Jul 22, 2026
| implementation libs.jose4j // for SASL/OAUTHBEARER JWT validation | ||
| implementation libs.jacksonJakartarsJsonProvider | ||
|
|
||
| compileOnly libs.spotbugs |
Member
There was a problem hiding this comment.
Could you remove testImplementation libs.spotbugs as well?
Collaborator
Author
There was a problem hiding this comment.
Sure, addressed it.
chia7712
reviewed
Jul 22, 2026
| testImplementation testLog4j2Libs | ||
|
|
||
| testRuntimeOnly runtimeTestLibs | ||
| testRuntimeOnly libs.junitPlatformLanucher |
Member
There was a problem hiding this comment.
ugh, that is a typo: junitPlatformLanucher 😆
we can address it in a follow-up
chia7712
approved these changes
Jul 22, 2026
Member
|
@m1a2st would you mind creating a follow-up PR to remove |
Collaborator
Author
|
Sure, I will open a patch to address it |
chia7712
pushed a commit
that referenced
this pull request
Jul 24, 2026
See the comment: #22903 (comment) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
nileshkumar3
pushed a commit
to nileshkumar3/kafka
that referenced
this pull request
Jul 25, 2026
Cleanup unused dependencies in `build.gradle` 1. `libs.spotbugs`: he SpotBugs Gradle plugin performs static analysis using its own bundled jar, it does not require this compile-time dependency. 2. `libs.jacksonJDK8Datatypes`: Jackson 2.15+ baked Optional support directly into jackson-databind core. 3. `libs.jmhCoreBenchmarks`: Benchmarks only use jmh-core (annotations, Blackhole, Runner) and jmh-generator-annprocess. No source file imports anything from the org.openjdk.jmh.samples or benchmarks package. 4. `libs.bndlib`: Safely removed as no modules currently depend on it. 5. `libs.jacksonDataformatYaml` & `libs.junitPlatformLanucher`: Removed from individual submodules because they are already globally included in the runtimeTestLibs array. 6. `libs.caffeine` & `libs.hdrHistogram`: group-coordinator does not use them 7. `libs.jacksonDataformatCsv`, `libs.jacksonJakartarsJsonProvider`, and `libs.junitPlatformSuiteEngine`: Removed from specific modules as they are either no longer directly imported or handled implicitly Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
nileshkumar3
pushed a commit
to nileshkumar3/kafka
that referenced
this pull request
Jul 25, 2026
See the comment: apache#22903 (comment) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup unused dependencies in
build.gradlelibs.spotbugs: he SpotBugs Gradle plugin performs static analysisusing its own bundled jar, it does not require this compile-time
dependency.
libs.jacksonJDK8Datatypes: Jackson 2.15+ baked Optional supportdirectly into jackson-databind core.
libs.jmhCoreBenchmarks: Benchmarks only use jmh-core (annotations,Blackhole, Runner) and jmh-generator-annprocess. No source file imports
anything from the org.openjdk.jmh.samples or benchmarks package.
libs.bndlib: Safely removed as no modules currently depend on it.libs.jacksonDataformatYaml&libs.junitPlatformLanucher: Removedfrom individual submodules because they are already globally included in
the runtimeTestLibs array.
libs.caffeine&libs.hdrHistogram: group-coordinator does not usethem
libs.jacksonDataformatCsv,libs.jacksonJakartarsJsonProvider, andlibs.junitPlatformSuiteEngine: Removed from specific modules as theyare either no longer directly imported or handled implicitly
Reviewers: Chia-Ping Tsai chia7712@gmail.com