KAFKA-18584: Fix controller restart in combined mode - #23043
Open
lh0156 wants to merge 1 commit into
Open
Conversation
Exercise the controller restart test in both isolated and combined KRaft modes. In combined mode, the broker still owns the shared Raft manager while the controller is restarted, so controller shutdown must not tear it down. Tests: ./gradlew :test-common:test-common-runtime:test --tests org.apache.kafka.common.test.junit.ClusterTestExtensionsTest --no-build-cache --console=plain Generated-by: OpenAI Codex (GPT-5) Signed-off-by: 엄윤섭 <62834176+lh0156@users.noreply.github.com>
github-actions
Bot
added
triage
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes KAFKA-18584
Summary
testControllerRestartunder both isolated and combined KRaft modes.In combined mode,
ControllerServer.shutdown()previously shut down the shared Raft manager even though the broker continued using it. Restarting the controller could then observe a null manager and fail with the NPE reported in KAFKA-18584. The lifecycle guard preserves the manager until the broker releases it.Tests
./gradlew :test-common:test-common-runtime:test --tests org.apache.kafka.common.test.junit.ClusterTestExtensionsTest --no-build-cache --console=plain./gradlew :core:spotlessCheck :test-common:test-common-runtime:spotlessCheck --no-build-cache --console=plain./gradlew :core:checkstyleMain :test-common:test-common-runtime:checkstyleTest --no-build-cache --console=plainThe targeted regression test passed three fresh reruns for both KRaft modes, and the full
ClusterTestExtensionsTestpassed.