KAFKA-16987: Release connector resources after failure - #23056
Open
lh0156 wants to merge 1 commit into
Open
Conversation
Release connector-owned resources as soon as a connector enters FAILED while preserving the FAILED status for subsequent STOPPED requests. Add lifecycle tests covering initialization, startup, external, and cleanup failures for source and sink connectors. Generated-by: OpenAI Codex (GPT-5) Signed-off-by: Yunseop Eom <62834176+lh0156@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a connector enters FAILED during initialization, startup, or an external failure notification, connector-owned resources can remain allocated until a later shutdown request. This change performs the failure cleanup immediately while preserving FAILED status so a later STOPPED target-state request can still be processed.
The cleanup calls connector.stop() at most once for each start lifecycle, preserves the original failure if stop() also throws, and continues closing the connector context, metrics, and offset resources.
Testing
./gradlew :connect:runtime:test --tests org.apache.kafka.connect.runtime.WorkerConnectorTest./gradlew :connect:runtime:test --tests org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testStoppedState./gradlew :connect:runtime:spotlessCheck :connect:runtime:checkstyleMain :connect:runtime:checkstyleTest :connect:runtime:spotbugsMain./gradlew :connect:runtime:testcompleted 1,529 tests with one unrelated timing-sensitive OffsetStorageReader test failure; that test passed when rerun independently.This contribution is my original work, and I license it to the Apache Software Foundation under the Apache License, Version 2.0.