KAFKA-20855: Extract bootstrap resolution from NetworkClient - #23066
Open
lh0156 wants to merge 4 commits into
Open
KAFKA-20855: Extract bootstrap resolution from NetworkClient#23066lh0156 wants to merge 4 commits into
lh0156 wants to merge 4 commits into
Conversation
Generated-by: OpenAI Codex (GPT-5) Signed-off-by: Yunseop Eom <62834176+lh0156@users.noreply.github.com>
Generated-by: OpenAI Codex (GPT-5) Signed-off-by: Yunseop Eom <62834176+lh0156@users.noreply.github.com>
Generated-by: OpenAI Codex (GPT-5) Signed-off-by: Yunseop Eom <62834176+lh0156@users.noreply.github.com>
Verify that disabling bootstrap resolution neither starts DNS work nor reports metadata changes. Keep the lifecycle contract explicit while extracting bootstrap resolution from NetworkClient. Generated-by: OpenAI Codex (GPT-5) Signed-off-by: Yunseop Eom <62834176+lh0156@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KIP-909 added asynchronous bootstrap DNS resolution state to
NetworkClient. This change extracts that state machine into the package-privateBootstrapServerResolversoNetworkClientremains focused on network I/O and metadata coordination.The behavior is unchanged: resolution starts eagerly, the timeout starts on the first poll, completed results are processed before the deadline check, failed or empty resolutions retry with the configured backoff, and close/interrupt paths cancel outstanding work. There are no public API, configuration, protocol, or wire-format changes.
Test Strategy
The resolver tests define the lifecycle contract for successful resolution, empty-result retry, exceptional-result retry, and timeout failure before the implementation is integrated. Existing
NetworkClientTestbootstrap and networking coverage remains green.Verified with:
./gradlew :clients:test --tests org.apache.kafka.clients.BootstrapServerResolverTest --tests org.apache.kafka.clients.NetworkClientTest./gradlew :clients:spotlessCheck :clients:checkstyleMain :clients:checkstyleTest :clients:spotbugsMain