KAFKA-20881: Select the correct Connect module JAR in system tests - #23076
Merged
Conversation
Contributor
Author
|
Tested locally with: Result: |
FrankYang0529
approved these changes
Aug 4, 2026
chia7712
reviewed
Aug 5, 2026
| file_path = lib_dir + file | ||
| self.logger.info("Appending %s to Connect worker's CLASSPATH" % file_path) | ||
| return "export CLASSPATH=${CLASSPATH}:%s; " % file_path | ||
| jar_name = "connect-%s-%s.jar" % (module, DEV_VERSION) |
Member
There was a problem hiding this comment.
As long as we only add dev version files, this approach is safe and simpler
chia7712
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connect system tests currently add the first JAR returned by
os.walkto the worker classpath, which may select a javadoc JAR instead of the
executable module JAR.
This change uses
DEV_VERSIONto construct and select the exactexpected JAR for each Connect module, removing the dependency on
filesystem traversal order.
Reviewers: PoAn Yang payang@apache.org, Ken Huang
s7133700@gmail.com, Chia-Ping Tsai chia7712@gmail.com