Skip to content

KAFKA-20881: Select the correct Connect module JAR in system tests - #23076

Merged
chia7712 merged 1 commit into
apache:trunkfrom
majialoong:KAFKA-20881
Aug 5, 2026
Merged

KAFKA-20881: Select the correct Connect module JAR in system tests#23076
chia7712 merged 1 commit into
apache:trunkfrom
majialoong:KAFKA-20881

Conversation

@majialoong

@majialoong majialoong commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Connect system tests currently add the first JAR returned by os.walk
to the worker classpath, which may select a javadoc JAR instead of the
executable module JAR.

This change uses DEV_VERSION to construct and select the exact
expected JAR for each Connect module, removing the dependency on
filesystem traversal order.

Reviewers: PoAn Yang payang@apache.org, Ken Huang
s7133700@gmail.com, Chia-Ping Tsai chia7712@gmail.com

@github-actions github-actions Bot added tests Test fixes (including flaky tests) small Small PRs labels Aug 4, 2026
@majialoong

Copy link
Copy Markdown
Contributor Author

Tested locally with:

./gradlew clean
./gradlew -p connect javadocJar
TC_PATHS=tests/kafkatest/tests/connect bash tests/docker/run_tests.sh

Result:

================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.14.0
session_id:       2026-08-04--001
run time:         183 minutes 44.404 seconds
tests run:        145
passed:           145
flaky:            0
failed:           0
ignored:          0
================================================================================

@github-actions github-actions Bot added the triage PRs from the community label Aug 4, 2026

@m1a2st m1a2st left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@github-actions github-actions Bot removed the triage PRs from the community label Aug 5, 2026
file_path = lib_dir + file
self.logger.info("Appending %s to Connect worker's CLASSPATH" % file_path)
return "export CLASSPATH=${CLASSPATH}:%s; " % file_path
jar_name = "connect-%s-%s.jar" % (module, DEV_VERSION)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we only add dev version files, this approach is safe and simpler

@chia7712
chia7712 merged commit 6425799 into apache:trunk Aug 5, 2026
27 checks passed
@majialoong
majialoong deleted the KAFKA-20881 branch August 6, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants