KAFKA-20385 [3/N]: Null-check for listener regn on AsyncKafkaConsumer - #23101
KAFKA-20385 [3/N]: Null-check for listener regn on AsyncKafkaConsumer#23101adikou wants to merge 5 commits into
Conversation
github-actions
Bot
added
triage
I thought it was too small a change for that. Is it a required field? I can add some context if needed |
No patch should be for nothing :) |
Fair enough. |
|
@adikou you could rebase code to trigger CI :) |
| acquireAndEnsureOpen(); | ||
| subscriptions.setRebalanceListener(listener, this); | ||
| if (listener != null) | ||
| subscriptions.setRebalanceListener(listener, this); |
There was a problem hiding this comment.
shoudl we move this after the throwIfGroupIdNotDefined and pattern checks below? (would be weird to set the listener and then fail)
There was a problem hiding this comment.
sgtm. Fixed and pushed
lianetm
left a comment
lianetm
left a comment
There was a problem hiding this comment.
Thanks! LGTM, let's just wait for the build
Thanks for the approval. Not sure why the build is failing. CI Action is not too clear |
Ah. https://x.com/githubstatus/status/2085464502028398833?s=46 |
|
Last run was a success |
3 participants
Added missing null check on listener registration for regex subscription. The bug would have unregistered any previously set listener in the consumer.
Reviewers: Chia-Ping Tsai chia7712@gmail.com, Lianet Magrans lmagrans@confluent.io