KAFKA-20632: Extend existing tests - #23135
Open
Nikita-Shupletsov wants to merge 1 commit into
Open
Conversation
…mental allocation strategy.
github-actions
Bot
added
triage
lianetm
reviewed
Aug 12, 2026
| @Test | ||
| public void testAppendLargeCompressed() throws Exception { | ||
| testAppendLarge(Compression.gzip().build()); | ||
| testAppendLarge(BUFFER_MEMORY_ALLOCATION_STRATEGY_FULL, Compression.gzip().build()); |
Member
There was a problem hiding this comment.
let's create a jira to re-enable these compression ones for incremental once it supports it?
| int stickyBatchSize, boolean rackAware, String rack) { | ||
| return new SequentialPartitioner(logContext, topic, stickyBatchSize, rackAware, rack); | ||
| BufferPool pool = createTestBufferPool(allocationStrategy, totalSize, batchSize, "producer-internal-metrics"); | ||
| RecordAccumulator accum = allocationStrategy.equals(ProducerConfig.BUFFER_MEMORY_ALLOCATION_STRATEGY_INCREMENTAL) |
Member
There was a problem hiding this comment.
can we reuse the createTestRecordAccumulator here?
| public void testTransitionToAbortableErrorOnBatchExpiry() throws InterruptedException { | ||
| @ParameterizedTest | ||
| @MethodSource("allocationStrategies") | ||
| public void testTransitionToAbortableErrorOnBatchExpiry(String allocationStrategy) throws InterruptedException { |
Member
There was a problem hiding this comment.
I would expect this test at the transaction mgr level is unaffected by chunks/allocation stategy so no need to parametrize?
| public void testTransitionToAbortableErrorOnMultipleBatchExpiry() throws InterruptedException { | ||
| @ParameterizedTest | ||
| @MethodSource("allocationStrategies") | ||
| public void testTransitionToAbortableErrorOnMultipleBatchExpiry(String allocationStrategy) throws InterruptedException { |
| public void testDropCommitOnBatchExpiry() throws InterruptedException { | ||
| @ParameterizedTest | ||
| @MethodSource("allocationStrategies") | ||
| public void testDropCommitOnBatchExpiry(String allocationStrategy) throws InterruptedException { |
| public void testTransitionToFatalErrorWhenRetriedBatchIsExpired() throws InterruptedException { | ||
| @ParameterizedTest | ||
| @MethodSource("allocationStrategies") | ||
| public void testTransitionToFatalErrorWhenRetriedBatchIsExpired(String allocationStrategy) throws InterruptedException { |
| @ParameterizedTest | ||
| @ValueSource(booleans = {true, false}) | ||
| public void testHealthyPartitionRetriesDuringEpochBump(boolean transactionV2Enabled) throws InterruptedException { | ||
| @MethodSource("transactionV2AndAllocationStrategies") |
| @ParameterizedTest | ||
| @MethodSource("allocationStrategies") | ||
| public void testDrainWithANodeThatDoesntHostAnyPartitions(String allocationStrategy) { | ||
| // Nothing is ever appended here, so batch.size only has to stay above the chunk size. |
Member
There was a problem hiding this comment.
why does it need to be above chunk here? (I would expect it if we were flowing through the KafkaProducer that ignores incremental if batch < chunk, but not here at the acc level, so why this batch change?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to verify the correctness of incremental allocation strategy.
Reviewers: Lianet Magrans lmagrans@confluent.io