KAFKA-20949: Remove hamcrest from org.apache.kafka.streams.query package - #23177
Merged
Conversation
chia7712
reviewed
Aug 24, 2026
| public void shouldNotEqualNull() { | ||
| final PositionBound bound1 = PositionBound.at(Position.emptyPosition()); | ||
| assertNotEquals(bound1, null); | ||
| assertNotNull(bound1); |
Member
There was a problem hiding this comment.
This test is used to verify equals(null), so it seems we should keep it as it was.
| assertEquals(Set.of("topic", "topic1"), merged.getTopics()); | ||
| assertEquals(mkMap(mkEntry(0, 5L)), merged.getPartitionPositions("topic")); | ||
| assertEquals(mkMap( | ||
| mkEntry(0, 5L), |
Member
There was a problem hiding this comment.
Please remove redundant indent
| assertEquals(Set.of("topic", "topic1", "topic2"), position.getTopics()); | ||
| assertEquals(mkMap(mkEntry(0, 6L)), position.getPartitionPositions("topic")); | ||
| assertEquals(mkMap( | ||
| mkEntry(0, 5L), |
| mkEntry(7, 0L) | ||
| ))); | ||
| assertEquals(mkMap( | ||
| mkEntry(0, 5L), |
| assertEquals(Set.of("topic", "topic1", "topic2"), merged.getTopics()); | ||
| assertEquals(mkMap(mkEntry(0, 7L)), merged.getPartitionPositions("topic")); | ||
| assertEquals(mkMap( | ||
| mkEntry(0, 5L), |
| assertEquals(Set.of("topic", "topic1"), copy.getTopics()); | ||
| assertEquals(mkMap(mkEntry(0, 5L)), copy.getPartitionPositions("topic")); | ||
| assertEquals(mkMap( | ||
| mkEntry(0, 5L), |
Member
Author
|
Thanks for the review, I pushed an update |
Member
@mimaison please push a fix for the build failure |
Member
Author
|
My bad, updated |
chia7712
reviewed
Aug 27, 2026
| public void shouldNotMatchNull() { | ||
| final Position position = Position.emptyPosition(); | ||
| assertNotEquals(position, null); | ||
| assertNotNull(position); |
Member
There was a problem hiding this comment.
It was used to verify the behavior of position.equals(null)
chia7712
reviewed
Aug 28, 2026
| public void shouldNotEqualNull() { | ||
| final PositionBound bound1 = PositionBound.at(Position.emptyPosition()); | ||
| assertNotEquals(bound1, null); | ||
| assertNotEquals(null, bound1); |
Member
There was a problem hiding this comment.
It should be assertNotEquals(bound1, null);
| public void shouldNotMatchNull() { | ||
| final Position position = Position.emptyPosition(); | ||
| assertNotEquals(position, null); | ||
| assertNotEquals(null, position); |
Member
There was a problem hiding this comment.
It should be assertNotEquals(position, null);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate usages of hamcrest to junit
Reviewers: Chia-Ping Tsai chia7712@gmail.com