Skip to content

MINOR: fix ClientRebootstrapTest verification and admin cleanup - #23231

Merged
m1a2st merged 1 commit into
apache:trunkfrom
Mirai1129:MINOR-improve-ClientRebootstrapTest
Aug 23, 2026
Merged

MINOR: fix ClientRebootstrapTest verification and admin cleanup#23231
m1a2st merged 1 commit into
apache:trunkfrom
Mirai1129:MINOR-improve-ClientRebootstrapTest

Conversation

@Mirai1129

@Mirai1129 Mirai1129 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Related to this
comment,

  • Verify TOPIC existence with assertTrue.
  • Ensure the Admin client is always closed with try-finally.

Reviewers: Uros (github:uros-b), Ken Huang s7133700@gmail.com,
Chia-Ping Tsai chia7712@gmail.com

@github-actions github-actions Bot added triage PRs from the community tests Test fixes (including flaky tests) clients small Small PRs labels Aug 21, 2026
@uros-b

uros-b commented Aug 21, 2026

Copy link
Copy Markdown
Member

+1, LGTM

@github-actions github-actions Bot removed the triage PRs from the community label Aug 22, 2026

@m1a2st m1a2st left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@chia7712 chia7712 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m1a2st
m1a2st merged commit 9f1512a into apache:trunk Aug 23, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved clients small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants