KAFKA-19895: Retry log cleaning after topic config updates - #23305
Open
arnabnandy7 wants to merge 1 commit into
Open
KAFKA-19895: Retry log cleaning after topic config updates#23305arnabnandy7 wants to merge 1 commit into
arnabnandy7 wants to merge 1 commit into
Conversation
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KAFKA-19895: This change allows log cleaning to recover without a broker restart after a partition has been marked as uncleanable.
When an unexpected exception occurs during cleaning, Kafka marks the affected partition as uncleanable and excludes it from subsequent compaction and deletion passes. This state is retained in memory, so updating the topic’s cleanup or retention configuration does not currently retry the partition. This can cause affected partitions, including
__consumer_offsetspartitions, to grow indefinitely until the broker is restarted.Changes
uncleanable-bytesmetric and recovery procedure.Testing
Added unit coverage to verify that:
Tests commands: