Make sure we don't have any files with names longer than 143 characters - #1112
Merged
Conversation
longer than 143 characters. 143 characters seems to be the limit for ecryptfs file system layered on top of ext4. Source: https://askubuntu.com/questions/361976/find-files-with-a-minimum-filename-length Part of LIBCLOUD-946.
Member
Author
|
I think we should do v2.2.1 after the fix is confirmed. @tonybaloney wdyt? |
Kami
changed the title
Member
Author
|
It looks like Travis is having some issues though. Build has been stuck for a long time now. |
asfgit
pushed a commit
that referenced
this pull request
Sep 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like 2.2.0 broke installation on some systems, because we now ship files with names longer than 143 characters.
Most modern operating systems and file systems support file names with lengths up to 255 characters, but it looks like using an encrypted file system (layering ecryptfs on top of ext3/4) drops this limit to 143 characters (see https://stackoverflow.com/questions/34503540/why-does-python-give-oserror-errno-36-file-name-too-long-for-filename-short).
This pull request fixes that and add a CI check which will catch issues like that in the future.
Resolves https://issues.apache.org/jira/browse/LIBCLOUD-946.