Libcloud 353 implement storage volume methods for openstack

[bernieke]

Implements storage volume methods for the openstack driver.

[Kami]

Thanks.

I quickly glanced over it and this patch looks good and fits into the current model.

I still need to do a proper review, but I plan to merge it if there aren't any objections after I perform the review.

@alex is currently also looking into improving block storage support in Libcloud so we should also figure out how this fits into his stuff.

[alex]

I think this fits in well with the model we're discussing now on the list, so I'll try to give this a review.

[Kami]

@alex Sweet, thanks

[alex]

This doesn't seem to handle snapshots, so it should raise an error if a snapshot is provided.

[alex]

Besides these comments, this looks good to me.

[bernieke]

Awesome.

I'm on vacation next week, but as soon as I get back I'll check the behavior of openstack in these cases, and make the necessary changes.

Thanks for the quick turnaround!

[bernieke]

I've addressed your remarks in a second commit: https://github.com/bernieke/libcloud/commit/456261fb379f5629ce0f047a757b8307ce181dca

[Kami]

Here, this should probably be OpenStackException and not CloudStackException :)

We recently also added a new ProviderError base exception class (

libcloud/libcloud/common/types.py

Line 67 in cb9d374

class ProviderError(LibcloudError):

) for error like this, so please make sure this class inherits from it.

[bernieke]

I've switched to the ProviderError exception class, and fixed the name of the exception (good catch :))

This is the commit with the change: https://github.com/bernieke/libcloud/commit/c72e6bafc3b75716094454fa404236644d11df20

[Kami]

Looks good, please attach patch to your JIRA ticket and I'll get it merged.

[bernieke]

commits squashed, patch attached to https://issues.apache.org/jira/browse/LIBCLOUD-353