Support disk_size parameter for create_node#1386
Merged
asfgit merged 2 commits intoapache:trunkfrom Dec 13, 2019
yukw777:gce-create-node-disk-size
Merged
Support disk_size parameter for create_node#1386asfgit merged 2 commits intoapache:trunkfrom yukw777:gce-create-node-disk-size
asfgit merged 2 commits intoapache:trunkfrom
yukw777:gce-create-node-disk-size
Conversation
7 tasks
Codecov Report
@@ Coverage Diff @@
## trunk #1386 +/- ##
==========================================
+ Coverage 86.26% 86.27% +<.01%
==========================================
Files 372 372
Lines 76355 76362 +7
Branches 6981 6981
==========================================
+ Hits 65870 65879 +9
+ Misses 7688 7687 -1
+ Partials 2797 2796 -1
Continue to review full report at Codecov.
|
Kami
reviewed
Dec 13, 2019
| ex_can_ip_forward, ex_disks_gce_struct, ex_nic_gce_struct, | ||
| ex_on_host_maintenance, ex_automatic_restart, ex_preemptible, | ||
| ex_subnetwork, ex_labels, ex_accelerator_type, | ||
| ex_accelerator_count) |
Member
There was a problem hiding this comment.
To avoid potential bugs it would probably be safer to use keyword instead of positional argumentshere in the future, but this also works for now since other arguments are already positional.
Contributor
Author
There was a problem hiding this comment.
I definitely agree, and actually was thinking about fixing it, but then decided against it so as to keep the scope of this PR small.
Member
|
Merged, thanks for contribution. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support disk_size parameter for create_node
Description
I've added support for
disk_sizeincreate_node()for GCE. This closely follows the change that added the same forex_create_multiple_nodes(). This is so that we can launch nodes on GCE with different sizes of disks easily.Status
Checklist (tick everything that applies)