Skip to content

Correct disk_size parameter support for create_node#1388

Merged
Kami merged 2 commits intoapache:trunkfrom
yukw777:gce-disk-size-fix
Dec 18, 2019
Merged

Correct disk_size parameter support for create_node#1388
Kami merged 2 commits intoapache:trunkfrom
yukw777:gce-disk-size-fix

Conversation

@yukw777
Copy link
Copy Markdown
Contributor

@yukw777 yukw777 commented Dec 18, 2019

Correct disk_size parameter support for create_node

Description

I realized my previous PR (#1386) wasn't quite correct as I wasn't passing in the parameter to the correct place. This fixes it.

Status

done, ready for review

Checklist (tick everything that applies)

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1388 into trunk will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #1388      +/-   ##
==========================================
+ Coverage   86.27%   86.27%   +<.01%     
==========================================
  Files         372      372              
  Lines       76539    76541       +2     
  Branches     7003     7003              
==========================================
+ Hits        66035    66037       +2     
  Misses       7700     7700              
  Partials     2804     2804
Impacted Files Coverage Δ
libcloud/compute/drivers/gce.py 76.81% <ø> (ø) ⬆️
libcloud/test/compute/test_gce.py 97.8% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc99f2...821654c. Read the comment docs.

@yukw777 yukw777 mentioned this pull request Dec 18, 2019
7 tasks
@Kami Kami merged commit 602cb6f into apache:trunk Dec 18, 2019
@Kami
Copy link
Copy Markdown
Member

Kami commented Dec 18, 2019

Merged, thanks.

And yes, using keyword args is definitely preferred and much more robust and less error prone.

On a related note - can you please work on submitting an ICLA?

@yukw777 yukw777 deleted the gce-disk-size-fix branch December 18, 2019 20:10
@yukw777
Copy link
Copy Markdown
Contributor Author

yukw777 commented Dec 18, 2019

@Kami i'll work on my ICLA now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants