Correct disk_size parameter support for create_node#1388
Merged
Kami merged 2 commits intoapache:trunkfrom Dec 18, 2019
yukw777:gce-disk-size-fix
Merged
Correct disk_size parameter support for create_node#1388Kami merged 2 commits intoapache:trunkfrom yukw777:gce-disk-size-fix
Kami merged 2 commits intoapache:trunkfrom
yukw777:gce-disk-size-fix
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #1388 +/- ##
==========================================
+ Coverage 86.27% 86.27% +<.01%
==========================================
Files 372 372
Lines 76539 76541 +2
Branches 7003 7003
==========================================
+ Hits 66035 66037 +2
Misses 7700 7700
Partials 2804 2804
Continue to review full report at Codecov.
|
7 tasks
Member
|
Merged, thanks. And yes, using keyword args is definitely preferred and much more robust and less error prone. On a related note - can you please work on submitting an ICLA? |
Contributor
Author
|
@Kami i'll work on my ICLA now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct disk_size parameter support for create_node
Description
I realized my previous PR (#1386) wasn't quite correct as I wasn't passing in the parameter to the correct place. This fixes it.
Status
done, ready for review
Checklist (tick everything that applies)