Pass siteMvn as a String so the site stage runs on Maven 4 - #331
Merged
Conversation
asfMavenTlpPlgnBuild passes siteMvn straight to doCreateTask, which does
jenkinsEnv.mvnFromVersion(os, "${maven}"). A Groovy List interpolates to
the literal "[4.0.x]", which matches no case in mvnFromVersion and falls
through to "default: return 'maven_3_latest'" - so the site stage silently
ran on Maven 3. The maven: parameter is unaffected because the shared
library iterates that list before passing each element.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
siteMvnis passed todoCreateTaskwhole, not iterated:and
doCreateTaskdoesjenkinsEnv.mvnFromVersion(os, "${maven}"). A Groovy List stringifies to"[4.0.x]", which matches nocaseinmvnFromVersionand falls through todefault: return 'maven_3_latest'— so the site stage has been running on Maven 3 with no error. Passing a String fixes it.maven:is correctly a List — that one is iterated (for (def mvn in mavens)). OnlysiteMvnhas this problem. apache/maven-deploy-plugin already passes it as a String.Verified by reading the shared library only; a Jenkins pipeline cannot be run locally. Note this does not by itself turn the Jenkins build green —
maven_4_lateston the build nodes still resolves to 4.0.0-rc-5, so a pom with<prerequisites>of rc-6 is rejected either way. This change makes the configuration do what it already says.