Migrate the site descriptor to the v2 model - #552
Merged
Conversation
Doxia Sitetools warns that the pre-2.0.0 site model will break in a future version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site descriptor was still the v1
<project xmlns=".../DECORATION/1.8.0">model, which makes every site build log "You MUST migrate to the new model as soon as possible otherwise your build will break in the future". It holds only menus, so the conversion is the root element and the namespace. Last of the estate sweep — the other fifteen repositories are in review now.Overlaps with #536, deliberately flagged rather than merged around. That PR fixes the
schemaLocationin this same file, which pointedDECORATION/1.8.0atdecoration-1.0.0.xsd. The two changes sit at different layers: #536 corrects the v1 declaration, this one leaves v1 behind and deletes that line. Its other hunk, the doubled slash indownload.xml.vm, is untouched here and still wanted either way.Whichever lands second needs a trivial rebase. I have no preference on the order; if #536 goes first I will rebase this one.
Verified: descriptor validates against
site-2.1.0.xsd;mvn site→ BUILD SUCCESS with the warning gone from the log.This change was created with AI assistance.