Skip to content

Inherit the maven-invoker-plugin version from the parent - #435

Merged
slachiewicz merged 1 commit into
masterfrom
inherit-invoker-plugin-version
Aug 9, 2026
Merged

Inherit the maven-invoker-plugin version from the parent#435
slachiewicz merged 1 commit into
masterfrom
inherit-invoker-plugin-version

Conversation

@slachiewicz

Copy link
Copy Markdown
Member

The local version.maven-invoker-plugin property pins 3.9.1. That was a bump when it was added, but org.apache:apache:39 — reached through the parent chain — now manages 3.10.1, so the property had quietly turned into a downgrade.

It is not just stale. maven-invoker-plugin 3.9.1 brings in Groovy 4.0.27, whose bundled ASM cannot read JDK 26 class files, so on a JDK 26 toolchain every verify.groovy post-build hook dies with:

java.lang.IllegalArgumentException: Unsupported class file major version 70
    at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:200)
    at org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)

The failure mode is nastier than a plain failure: the integration test's own build.log still ends in BUILD SUCCESS and only the post-build hook blows up, so a broken run and a good one look identical until you read the stack trace. 3.10.1 ships Groovy 4.0.31, which handles JDK 26.

So this drops the property rather than restating a version the parent already owns. mvn help:effective-pom confirms maven-invoker-plugin resolves to 3.10.1 with the line gone.

Part of a sweep across the Maven repositories for local pom properties that no longer override anything useful. The same change in apache/maven-checkstyle-plugin (#685) took its integration tests on JDK 26 from failing in the script interpreter to 49/49 passing.

Generated-by: Claude Opus 5 (1M context)

The local version.maven-invoker-plugin property pinned 3.9.1. That was a
bump when it was added, but org.apache:apache:39 now manages 3.10.1, so
the property had quietly become a downgrade.

It is not only stale. maven-invoker-plugin 3.9.1 brings in Groovy 4.0.27,
whose bundled ASM cannot read JDK 26 class files, so every verify.groovy
post-build hook dies with "Unsupported class file major version 70" while
the integration test's own build.log still reports success. 3.10.1 ships
Groovy 4.0.31, which handles JDK 26.

Drop the property rather than restate a version the parent already owns.

Generated-by: Claude Opus 5 (1M context)
@slachiewicz slachiewicz added maintenance dependencies Pull requests that update a dependency file labels Aug 9, 2026
@slachiewicz
slachiewicz marked this pull request as ready for review August 9, 2026 14:33
@slachiewicz
slachiewicz merged commit 0108c37 into master Aug 9, 2026
11 checks passed
@slachiewicz
slachiewicz deleted the inherit-invoker-plugin-version branch August 9, 2026 14:42
@github-actions github-actions Bot added this to the 4.0.0-beta-3 milestone Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant