Skip to content

MPLUGIN-421: Migrate legacy plugin Javadoc annotations - #1153

Merged
slachiewicz merged 1 commit into
apache:masterfrom
wilx:718-legacy-plugin-annotations
Aug 8, 2026
Merged

MPLUGIN-421: Migrate legacy plugin Javadoc annotations#1153
slachiewicz merged 1 commit into
apache:masterfrom
wilx:718-legacy-plugin-annotations

Conversation

@wilx

@wilx wilx commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Summary

Replace the remaining legacy @parameter and @required Javadoc tags in the plugin-report integration-test fixture with @Parameter metadata.

The rest of this fixture was migrated to maven-plugin-annotations in MPLUGIN-527, but the field-level tags were left behind. This change completes that conversion while preserving the required project.build.directory property expression. The fixture already has the annotation dependency, so no POM change is needed.

The generated descriptor contains:

<outputDirectory implementation="java.io.File">${project.build.directory}</outputDirectory>

This is an integration-test fixture cleanup and does not change production runtime behavior.

Related to #718.

Validation

The complete seven-module reactor and all integration tests passed on JDK 21 with both supported Maven lines:

Apache Maven 3.9.16:       mvn -B -V -Prun-its verify
Apache Maven 4.0.0-rc-6:  mvn -B -V -Prun-its verify

For each run, all 12 maven-plugin-report-plugin integration tests passed, including fix-maven-since-3.x. The plugin-plugin matrix passed 28 fixtures and skipped only the fixture intended for the other Maven major version.

Replace the remaining legacy parameter Javadoc tags in the plugin report integration-test fixture with maven-plugin-annotations metadata. Preserve the required project.build.directory property expression.
@wilx
wilx marked this pull request as ready for review August 8, 2026 14:26
@slachiewicz
slachiewicz merged commit b509cf7 into apache:master Aug 8, 2026
17 checks passed
@github-actions github-actions Bot added this to the 4.0.0-beta-3 milestone Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants