Skip to content

Convert to javax.inject constructor injection - #25

Merged
elharo merged 2 commits into
masterfrom
guice
Dec 1, 2024
Merged

Convert to javax.inject constructor injection#25
elharo merged 2 commits into
masterfrom
guice

Conversation

@elharo

@elharo elharo commented Dec 1, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread pom.xml
Comment on lines +113 to +117
<dependency>
<groupId>org.eclipse.sisu</groupId>
<artifactId>org.eclipse.sisu.plexus</artifactId>
<scope>provided</scope>
</dependency>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, according to mvn dependency:analyze:

[INFO] --- dependency:3.6.1:analyze (default-cli) @ maven-rar-plugin ---
[WARNING] Used undeclared dependencies found:
[WARNING]    org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.9.0.M2:provided
[WARNING] Unused declared dependencies found:
[WARNING]    org.apache.maven:maven-settings:jar:3.6.3:provided
[WARNING]    org.codehaus.plexus:plexus-interpolation:jar:1.27:compile
[WARNING]    org.codehaus.plexus:plexus-xml:jar:3.0.0:compile
[WARNING]    junit:junit:jar:4.13.2:test
[WARNING]    org.apache.maven:maven-compat:jar:3.6.3:test
[INFO] ------------------------------------------------------------------------

@elharo
elharo marked this pull request as ready for review December 1, 2024 18:44
@elharo
elharo merged commit cb5119c into master Dec 1, 2024
@elharo
elharo deleted the guice branch December 1, 2024 18:44
@slachiewicz slachiewicz added this to the 3.0.1 milestone Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants