Build against Maven 4.0.0-rc-6

[slachiewicz]

This plugin was still on 4.0.0-beta-3, the furthest behind of the 4-native plugins, and it is a migration rather than a version bump.

Dependencies. maven-api-meta and maven-api-impl no longer exist; they become maven-api-annotations and org.apache.maven:maven-testing respectively, matching what maven-jar-plugin already does. maven-archiver moved to org.apache.maven.shared.

Source roots. ProjectManager.getCompileSourceRoots(project, scope) and getResources(project, scope) are gone; resources and source roots are unified into SourceRoot:

before	after
getCompileSourceRoots(p, MAIN)	getEnabledSourceRoots(p, MAIN, Language.JAVA_FAMILY).map(SourceRoot::directory)
getResources(p, MAIN)	getEnabledSourceRoots(p, MAIN, Language.RESOURCES)
Resource.getDirectory()	SourceRoot.directory()
Resource.getIncludes() / getExcludes()	SourceRoot.includes() / excludes()
Resource.getTargetPath()	SourceRoot.targetPath()
session.createArtifact(...)	session.createProducedArtifact(...)

attachArtifact now takes a ProducedArtifact. The maven-shared-archive-resources special case moves onto the same SourceRoot stream. Include/exclude and target-path handling are preserved, so which files land in the sources jar should not change.

site.xml. The <skin> workaround is removed — its own comment said it was only needed on beta-3 and is redundant from rc-5 onwards.

Verification. mvn test: 10 tests, 0 failures. mvn verify -Prun-its: all 23 ITs pass.

Getting there needed a second commit. MSOURCES-140 was failing, and its assertion turned out to be unrunnable: verify.groovy:22 is a Groovy slashy-string regex containing the literal text " + File.separator + " — Java concatenation written inside a regex literal, which a slashy string does not evaluate. It cannot match on any platform. It went unnoticed because invoker.properties requires 4.0.0-beta-4+, so the IT was skipped on the beta-3 this plugin used to build against. The mojo does emit exactly what it looks for:

[INFO] Artifact ...:jar-no-fork:jar:sources:1.0-SNAPSHOT already attached to
target/jar-no-fork-1.0-SNAPSHOT-sources.jar: ignoring same re-attach (same artifact, same file)

Matching the separator as a character class makes it pass. Kept as its own commit so it can be dropped or split out if you would rather take it separately.

For reference, unmodified master cannot run its ITs under rc-6 at all — every mojo invocation dies with NoSuchMethodError: ProjectManager.getCompileSourceRoots, so 22 ITs go from failing to passing here.

Two judgement calls worth a reviewer's eye:

• createArchiver() looked up maven-shared-archive-resources through project.getBuild().getResources(), which is deprecated at rc-6. It now goes through ProjectManager, which is a superset — it also sees roots registered at runtime by maven-remote-resources-plugin, the very plugin that produces those resources. No test covers this path either way; it is a two-line revert if you prefer a literal translation.
• getEnabledSourceRoots requires a Language; JAVA_FAMILY is used for sources, matching maven-compiler-plugin. It also filters on enabled(), which the old call did not. Both look like the intent of the new API, but they are real semantic differences.

SourceRoot.stringFiltering() is deliberately not wired up: the beta-3 code never read Resource.getFiltering(), and honouring it now would change file contents in the jar.

Part of apache/maven#12676.

[desruisseaux]

I'm not yet familiar with the internal of the source plugin, but for the parts that I recognize it looks fine to me.

[sparsick]

@slachiewicz for this case a PR is already opened (see #268 )

[slachiewicz]

Closing in favour of #268, which I had not spotted — it is the same upgrade, opened in January and refreshed today, and it should have precedence.

For the record, the two overlap almost entirely: mavenVersion to rc-6, maven-api-meta → maven-api-annotations, maven-archiver moving to org.apache.maven.shared, the ProjectManager/SourceRoot migration, the workflow pin, and the MSOURCES-140 assertion. #268 also bumps the parent POM 47 → 49 and the plugin-plugin / plugin-testing versions, which mine did not.

Two small things here are not in #268, if they are wanted:

1. src/site/site.xml still carries a <skin> workaround whose own comment says it is only needed on beta-3 and is redundant from rc-5 onwards. Removing it is a clean follow-up now that the build is on rc-6.
2. AbstractSourcePluginTestCase still imports org.apache.maven.api.plugin.testing.MojoExtension.getBasedir. That compiles, because the deprecated shims are still there, but MojoExtension in rc-6 only honours the relocated annotations — see maven-testing: deprecated org.apache.maven.api.plugin.testing annotations compile but are silently ignored maven#12678, where the same thing silently broke maven-jar-plugin. Worth moving to org.apache.maven.testing.plugin while touching these files.

Happy to send either as a separate PR against master once #268 lands.