Remove Java 5 references and clean up - #24
Conversation
Mostly a copy edit for clarity. @slawekjaranowski
| Custom Toolchains | ||
|
|
||
| You can create your own custom toolchains with plugins using them. | ||
| You can create your own custom toolchains for plugins to use. |
There was a problem hiding this comment.
in fact, you need in 2 steps:
- create a toolchain
- have a plugin use it
There was a problem hiding this comment.
agree with @hboutemy - old sentence was more accurate for me also
There was a problem hiding this comment.
@elharo I'm thinking about release a new version of this plugin. Do you want to remove that line and merge the PR ?
There was a problem hiding this comment.
The old sentence is not OK. It is grammatically weird, and definitely ambiguous. There are at least two readings of it. I think the current sentence is accurate, but perhaps I misread the original. If so, please suggest alternate language.
There was a problem hiding this comment.
maybe You can create your own custom toolchains to use with standard plugins (such as maven-compiler-plugin) or custom plugins ?
There was a problem hiding this comment.
done, though I'm not sure "custom plugin" is really a thing. At this level, aren't they all just plugins?
…s (such as maven-compiler-plugin) or custom plugins
5 participants
Mostly a copy edit for clarity. @slawekjaranowski