[wagon-3.x] Fix NPE in ScpExternalWagon when localFile has no parent directory - #966
Merged
slachiewicz merged 1 commit intoSep 3, 2026
Merged
Conversation
This was referenced Sep 3, 2026
When localFile is specified as a bare relative filename (e.g. via mvn gpg:sign-and-deploy-file -Dfiles=artifact-sources.jar), localFile.getParentFile() returns null, causing a NullPointerException when calling getAbsolutePath(). Safely resolve the working directory to localFile.getAbsoluteFile().getParentFile() when localFile.getParentFile() is null, and add offline unit tests in ExternalScpWagonTest covering both relative and parented files. Co-authored-by: Sven Göthel <sgothel@jausoft.com>
slachiewicz
force-pushed
the
scpexe-relative-parent-3.x
branch
from
September 3, 2026 20:19
0be92bf to
43e57fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #817 with added unit test coverage and updated codebase conventions.
When
localFileis specified as a bare relative filename (such as viamvn gpg:sign-and-deploy-file -Dfiles=artifact-sources.jar),localFile.getParentFile()returnsnull, causing aNullPointerExceptionwhen callinglocalFile.getParentFile().getAbsolutePath().localFile.getAbsoluteFile().getParentFile()whenlocalFile.getParentFile()is null.ExternalScpWagonTestwith offline unit tests verifying commandline construction with both bare relative files and parented files, as well as PuTTY detection.Co-authored-by: Sven Göthel sgothel@jausoft.com