Stop wagon-http from publishing a dependency-reduced POM - #973
Merged
Conversation
The shaded jar is attached under a classifier, so the main jar keeps needing wagon-http-shared and httpclient; reducing the POM stripped them and left HttpWagon unloadable. Do not restore dependencyReducedPomLocation to fix WAGON-636 / #750 -- disabling the reduced POM outright means none is written to the basedir either.
slachiewicz
added
bug
slachiewicz
marked this pull request as ready for review
September 3, 2026 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wagon-http's main jar is unshaded and needswagon-http-sharedandhttpclientat runtime, but the shade execution was reducing them out of the installed POM, leavingHttpWagonunable to loadAbstractHttpClientWagon. Fixes #972.Verified:
mvn installon the module → installed POM declareswagon-http-shared,httpclientandhttpcoreagain; both the plain and-shadedjars still produced; nodependency-reduced-pom.xmlin the basedir, so #750 stays fixed. A rebuilt Maven 3.9.17-SNAPSHOT distribution shipswagon-http-sharedagain, and-Dmaven.resolver.transport=wagonselectsWagonTransporterfor both afile://repository and central, matching released 3.9.16.masterneeds the same change.This change was created with AI assistance.